Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Astro.site defaults to https://astro.build when not provided in the Astro config #3551

Closed
1 task done
tony-sull opened this issue Jun 6, 2022 · 1 comment · Fixed by #3552
Closed
1 task done

🐛 BUG: Astro.site defaults to https://astro.build when not provided in the Astro config #3551

tony-sull opened this issue Jun 6, 2022 · 1 comment · Fixed by #3552
Assignees
@tony-sull
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@tony-sull
Copy link
Contributor

What version of astro are you using?

1.0.0-beta.41

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

A quick search and I don't actually see where this comes from in the codebase, but Astro.site (on the Astro global) is defaulting to https://astro.build if site isn't defined in the project's config file

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-xwms6k

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P3: minor bug An edge case that only affects very specific usage (priority) s1-small labels Jun 6, 2022
@tony-sull tony-sull self-assigned this Jun 6, 2022
@tony-sull tony-sull transferred this issue from withastro/astro Jun 7, 2022
@tony-sull
Copy link
Contributor Author

Found it! Astro.site is being defaulted to https://astro.build in the compiler here

@tony-sull tony-sull transferred this issue from withastro/compiler Jun 7, 2022
@tony-sull tony-sull mentioned this issue Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tony-sull tony-sull

Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Astro.site should default to localhost if not provided in config withastro/astro
1 participant
@tony-sull