Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change comma color in light theme on error page #11373

Closed
1 task
teinett opened this issue Jun 29, 2024 · 0 comments · Fixed by #11388
Closed
1 task

Change comma color in light theme on error page #11373

teinett opened this issue Jun 29, 2024 · 0 comments · Fixed by #11388
Labels
- P2: nice to have Not breaking anything but nice to have (priority) good first issue Good for newcomers. If you need additional guidance, feel free to post in #dev on Discord

Comments

@teinett
Copy link

teinett commented Jun 29, 2024

Astro Info

Astro                    v4.11.3
Node                     v18.20.2
System                   macOS (arm64)
Package Manager          npm
Output                   hybrid
Adapter                  @astrojs/node
Integrations             @astrojs/react
                         @astrojs/mdx
                         @astrojs/sitemap
                         astro-meta-tags
                         astro-robots-txt

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

I have an error, and AstroJS shows me error page.

The code inside has commas, and it's almost invisible in light theme: white color on light-gray background.

Light theme with problem:

2024-06-29 12-10-12

Dark theme without problem:
2024-06-29 12-10-33

What's the expected result?

The color of commas is the same color that text.

Link to Minimal Reproducible Example

no code example

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jun 29, 2024
@ematipico ematipico added - P2: nice to have Not breaking anything but nice to have (priority) good first issue Good for newcomers. If you need additional guidance, feel free to post in #dev on Discord and removed needs triage Issue needs to be triaged labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) good first issue Good for newcomers. If you need additional guidance, feel free to post in #dev on Discord
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants