Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use %23 (#) in dynamic url #10983

Closed
1 task done
Elias-Chairi opened this issue May 9, 2024 · 3 comments · Fixed by #10965
Closed
1 task done

Unable to use %23 (#) in dynamic url #10983

Elias-Chairi opened this issue May 9, 2024 · 3 comments · Fixed by #10965
Labels
- P2: has workaround Bug, but has workaround (priority)

Comments

@Elias-Chairi
Copy link
Contributor

Astro Info

Astro                    v4.8.0
Node                     v20.11.1
System                   macOS (arm64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/solid-js

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When trying to load a dynamic url like alphabet/:letter.astro if the letter includes or is equal to %23 i get the error:

Expected "letter" to match "[^\/#\?]+?", but got "#"

What's the expected result?

I expect the page to load with the param resolving to either # or %23.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-x6hzgp?file=astro.config.mjs,src/pages/%5Bdynamic%5D.astro,src/pages/index.astro

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 9, 2024
@Elias-Chairi
Copy link
Contributor Author

Elias-Chairi commented May 9, 2024

I am not an expert of any kind :)
#10965

@bluwy bluwy linked a pull request May 9, 2024 that will close this issue
@ematipico
Copy link
Member

I think this is a duplicate of #8516

@Elias-Chairi
Copy link
Contributor Author

I am sorry, i might have explained it poorly. The example in #8516 is with paths generated with the getStaticPaths method in static or hybrid mode. My problem is with a path in ssr mode. The example path used in the other issue seems to work fine in a dynamic path in ssr mode.

@matthewp matthewp added - P2: has workaround Bug, but has workaround (priority) and removed needs triage Issue needs to be triaged labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: has workaround Bug, but has workaround (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants