From e4370e9e9dd862425eced25823c82e77d9516927 Mon Sep 17 00:00:00 2001 From: Tugrul Ates Date: Sat, 27 Jan 2024 01:41:23 +0300 Subject: [PATCH] fix(audit): mark widget roles as interactive (#9825) Co-authored-by: Nate Moore --- .changeset/old-actors-taste.md | 5 ++++ .../client/dev-toolbar/apps/audit/a11y.ts | 28 ------------------- 2 files changed, 5 insertions(+), 28 deletions(-) create mode 100644 .changeset/old-actors-taste.md diff --git a/.changeset/old-actors-taste.md b/.changeset/old-actors-taste.md new file mode 100644 index 000000000000..f11550a8c044 --- /dev/null +++ b/.changeset/old-actors-taste.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Fixes false positive aria role errors on interactive elements diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts index 6eb4cd97b597..ac1624cd9f2e 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts @@ -50,11 +50,8 @@ const aria_non_interactive_roles = [ 'application', 'article', 'banner', - 'button', 'cell', - 'checkbox', 'columnheader', - 'combobox', 'complementary', 'contentinfo', 'definition', @@ -64,55 +61,30 @@ const aria_non_interactive_roles = [ 'feed', 'figure', 'form', - 'grid', - 'gridcell', 'group', 'heading', 'img', - 'link', 'list', - 'listbox', 'listitem', 'log', 'main', 'marquee', 'math', - 'menu', - 'menubar', - 'menuitem', - 'menuitemcheckbox', 'menuitemradio', 'navigation', 'none', 'note', - 'option', 'presentation', - 'progressbar', - 'radio', - 'radiogroup', 'region', 'row', 'rowgroup', 'rowheader', - 'scrollbar', 'search', - 'searchbox', - 'separator', - 'slider', - 'spinbutton', 'status', - 'switch', - 'tab', - 'tablist', - 'tabpanel', 'term', - 'textbox', 'timer', 'toolbar', 'tooltip', - 'tree', - 'treegrid', - 'treeitem', ]; const a11y_required_content = [