Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for cable splicing #26

Closed
formatc1702 opened this issue Jun 27, 2020 · 5 comments
Closed

[feature] Add support for cable splicing #26

formatc1702 opened this issue Jun 27, 2020 · 5 comments

Comments

@formatc1702
Copy link
Collaborator

Possibly using a "pseudo-connector" linking e.g. one wire from the left and two wires from the right.

Proof-of-concept:

connectors:
  X1:
    pincount: 5
  X2:
    pincount: 8
  S1:
    category: ferrule # TODO: splice
    pincount: 1
    type: Solderjoint + Tape
    notes: splice
  S2:
    category: ferrule # TODO: splice
    pincount: 1
    type: Solderjoint + Tape
    notes: splice

cables:
  W1: &template_wire
    category: bundle
    wirecount: 3
    gauge: 0.25
    length: 1
    show_name: false
    colors: [PK]
  W2:
    <<: *template_wire
    wirecount: 2
    length: 0.8
    colors: [TQ, YE]
  W3:
    <<: *template_wire
    wirecount: 5
    length: 0.2
    colors: [TQ, TQ, YE, YE, YE]

connections:
  -
    - X1: [1-3]
    - W1: [1-3]
    - X2: [1-3]
  -
    - X1: [4,5]
    - W2: [1,2]
  -
    - W2: 1
    - S1: 1
  -
    - W2: 2
    - S2: 1
  -
    - S1: [1,1]
    - W3: [1,2]
    - X2: [4,5]
  -
    - S2: [1,1,1]
    - W3: [3,4,5]
    - X2: [6,7,8]

test

@kvid
Copy link
Collaborator

kvid commented Jun 27, 2020

Really nice! I guess a final solution can avoid the duplicated text "Solderjoint + Tape" inside the splice frame. :-)

@formatc1702
Copy link
Collaborator Author

formatc1702 commented Jun 27, 2020

Yes, this is just an artifact of the way ferrules are implemented now... splicing is on the roadmap, though!

I'm not quite sure why GraphViz makes the topmost wire bend like that, though... that's something I have little control over...

@formatc1702 formatc1702 changed the title Add support for cable splicing [feature] Add support for cable splicing Jun 28, 2020
@formatc1702
Copy link
Collaborator Author

formatc1702 commented Jul 5, 2020

I refactored the entire ferrule/splice section in #65, the bug with the double label is fixed, and splices now look good regardless of whether few or many attributes are specified.

test

I am considering to change the ferrule category name to simple, to encompass both ferrules, splices, and any other simple connectors that don't have a designator and essentially only have one port (electrically speaking, at least).

@kvid
Copy link
Collaborator

kvid commented Jul 6, 2020

I suggest this also can be used for any product to connect several wires in one physical point, e.g. a Wire Nut, as mentioned in issue #45 (comment)

@formatc1702
Copy link
Collaborator Author

I consider this completed and have included some of the thoughts in #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants