Remove invalid pending feedbacks

[ciriousjoker]

https://github.com/wiredashio/wiredash-sdk/blob/12973a8c40d73a06bae621616cf40ebc94926167/lib/src/feedback/data/pending_feedback_item.dart#L57C3-L71

One of our users apparently has a pending old feedback from an old version of the app. This creates a new error in Crashlytics everytime he opens the app.

Can't invalid feedbacks be automatically cleared from the persisted queue?

[passsy]

That's exactly what should happen. There is even a test for this exact case.

Can you give me the full stacktrace?

[ciriousjoker]

It seems to affect 3 users in total, two of them just once (expected) and one of them 88 times over the last 90 days.

Here are the different variants for the third users:

(flutter_error_exception followed by stacktrace)

Can't parse feedback without version

Non-fatal Exception: FlutterError
0 ??? 0x0 (null).deserializePendingFeedbackItem + 62 (pending_feedback_item.dart:62)
1 ??? 0x0 PendingFeedbackItemStorage.retrieveAllPendingItems + 40 (pending_feedback_item_storage.dart:40)
2 ??? 0x0 RetryingFeedbackSubmitter._submitPendingFeedbackItems + 84 (retrying_feedback_submitter.dart:84)
3 ??? 0x0 UploadPendingFeedbackJob.execute + 24 (sync_feedback_job.dart:24)
4 ??? 0x0 SyncEngine._triggerEvent + 128 (sync_engine.dart:128)

---

Invalid argument(s): Invalid type for "path": null

Non-fatal Exception: FlutterError
0 ??? 0x0 (null).deserializePendingFeedbackItem + 62 (pending_feedback_item.dart:62)
1 ??? 0x0 PendingFeedbackItemStorage.retrieveAllPendingItems + 40 (pending_feedback_item_storage.dart:40)
2 ??? 0x0 PendingFeedbackItemStorage._mutatePendingItems + 173 (pending_feedback_item_storage.dart:173)
3 ??? 0x0 PendingFeedbackItemStorage.addPendingItem + 108 (pending_feedback_item_storage.dart:108)
4 ??? 0x0 RetryingFeedbackSubmitter.submit + 37 (retrying_feedback_submitter.dart:37)
5 ??? 0x0 FeedbackModel.submitFeedback + 363 (feedback_model.dart:363)

---

PlatformException(561015905, Session activation failed, null, null)
(this seems to be an issue with a different plugin, don't read too much into it)

Non-fatal Exception: FlutterError
0 ??? 0x0 (null).deserializePendingFeedbackItem + 62 (pending_feedback_item.dart:62)
1 ??? 0x0 PendingFeedbackItemStorage.retrieveAllPendingItems + 40 (pending_feedback_item_storage.dart:40)
2 ??? 0x0 RetryingFeedbackSubmitter._submitPendingFeedbackItems + 84 (retrying_feedback_submitter.dart:84)
3 ??? 0x0 UploadPendingFeedbackJob.execute + 24 (sync_feedback_job.dart:24)
4 ??? 0x0 SyncEngine._triggerEvent + 128 (sync_engine.dart:128)