Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WiredashController.show asynchronous #295

Open
Nokiater opened this issue Aug 25, 2023 · 0 comments
Open

Make WiredashController.show asynchronous #295

Nokiater opened this issue Aug 25, 2023 · 0 comments
Labels
sdk This issue affects the sdk

Comments

@Nokiater
Copy link

Nokiater commented Aug 25, 2023

Is your feature request related to a problem? Please describe.

  1. When a user finished providing feedback after he submitted it, I would like to perform some follow-up actions. (P.e. to request an in-app review after user submitted feedback.) I don't think this is currently possible because the underlying WiredashModel.show() function is async while the exposed ModelController.show() wrapper function is not.

  2. In addition to this, it would also be useful to have access to the submitted data. P.e. I would like to enhance user-experience by persisting/caching the (optional) email-adress the user provided so I can prefill the email-adress in subsequent feedback message submissions

Describe the solution you'd like
The 1st enhancement is very easy. Since the underlying model's show() method is already async, this would involve changing just 1 line of code.

The additional enhancement would return the entered user-data in the return value.

Describe alternatives you've considered
I was unable to find any workaround to provide these desired features. I considered implementing my custom Controller by extending the WiredashController to override the show() method but as the underlying model is private, this doesn't seem to provide any solution.

Additional context
n/a

@Nokiater Nokiater added the sdk This issue affects the sdk label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk This issue affects the sdk
Projects
None yet
Development

No branches or pull requests

1 participant