refactor(react-ui-kit): Emotion v11 migration #3349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yserz
commented
Nov 27, 2020
| import {COLOR} from '../Identity/colors'; | ||
| import {filterProps} from '../util'; | ||
|
|
||
| // Apply custom theme to Emotion so TypeScript can pick it up in the css prop | ||
| declare module '@emotion/react' { |
There was a problem hiding this comment.
Theme needs to be augmented in order to have correct typing for the css prop theme parameter.
There was a problem hiding this comment.
Yserz
commented
Nov 27, 2020
| @@ -36,6 +36,9 @@ module.exports = { | |||
| resolve: { | |||
| alias: { | |||
| '@wireapp/react-ui-kit': path.resolve(__dirname, 'src'), | |||
| // Needed until libs have support for emotion v11 | |||
| // https://github.com/infinum/emotion-normalize/pull/12 | |||
| '@emotion/core': '@emotion/react', | |||
There was a problem hiding this comment.
We need to redirect calls from @emotion/core to @emotion/react until emotion-normalize supports it.
There was a problem hiding this comment.
|
Superseeded by #4254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emotion provides a good amount of compatibility from v10 to v11 but there are some areas that need to be migrated.
https://emotion.sh/docs/emotion-11
The main change from our perspective is the renaming of the
@emotion/corepackage to@emotion/react.