Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note on race condition in integration test. #2719

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Note on race condition in integration test. #2719

merged 5 commits into from
Sep 23, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Sep 21, 2022

(very small change, hopefully non-controversial.)

@fisx fisx temporarily deployed to cachix September 21, 2022 10:37 Inactive
@fisx fisx temporarily deployed to cachix September 21, 2022 10:37 Inactive
@fisx fisx temporarily deployed to cachix September 21, 2022 10:37 Inactive
@fisx fisx temporarily deployed to cachix September 21, 2022 10:37 Inactive
@fisx fisx marked this pull request as ready for review September 21, 2022 10:37
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 21, 2022
@fisx fisx temporarily deployed to cachix September 22, 2022 19:26 Inactive
@fisx fisx temporarily deployed to cachix September 22, 2022 19:26 Inactive
@fisx fisx temporarily deployed to cachix September 23, 2022 07:58 Inactive
@fisx fisx temporarily deployed to cachix September 23, 2022 07:58 Inactive
@fisx fisx temporarily deployed to cachix September 23, 2022 08:01 Inactive
@fisx fisx temporarily deployed to cachix September 23, 2022 08:01 Inactive
battermann
battermann approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hope it helps!

@fisx fisx temporarily deployed to cachix September 23, 2022 08:27 Inactive
@fisx fisx temporarily deployed to cachix September 23, 2022 08:27 Inactive
@fisx fisx merged commit 987c648 into develop Sep 23, 2022
@fisx fisx deleted the nit-pick-1478 branch September 23, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @battermann @zebot