Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQSERVICES-1643] Servantify brig account API 8 - POST /onboading/v3 #2707

Merged
merged 2 commits into from
Sep 23, 2022
Merged

[SQSERVICES-1643] Servantify brig account API 8 - POST /onboading/v3 #2707

merged 2 commits into from
Sep 23, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Sep 19, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1643

Todo

  • this is the last PR for SQSERVICES-1643, squash the changelog

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix September 19, 2022 13:14 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 13:14 Inactive
@battermann battermann changed the base branch from develop to SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key September 19, 2022 13:15
@battermann battermann changed the title Sqservices 1643 backend servantify brig account api 8 onboarding [SQSERVICES-1643] Servantify brig account API 8 - POST /onboading/v3 Sep 19, 2022
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 19, 2022
@battermann battermann temporarily deployed to cachix September 19, 2022 13:34 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 13:34 Inactive
@battermann battermann marked this pull request as ready for review September 19, 2022 13:34
@battermann battermann requested a review from fisx September 19, 2022 13:34
@battermann battermann temporarily deployed to cachix September 19, 2022 14:56 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 14:56 Inactive
akshaymankar
akshaymankar approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 4ce295f to 3e26053 Compare September 20, 2022 10:29
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-8-onboarding branch from 7c95cbe to ae2dcf3 Compare September 20, 2022 10:42
@battermann battermann temporarily deployed to cachix September 20, 2022 10:42 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 10:42 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 8665f08 to b344410 Compare September 23, 2022 07:09
Base automatically changed from SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key to develop September 23, 2022 09:31
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-8-onboarding branch from ae2dcf3 to f83a0ab Compare September 23, 2022 09:34
@battermann battermann temporarily deployed to cachix September 23, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 09:37 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 09:37 Inactive
@battermann battermann merged commit 363ffa4 into develop Sep 23, 2022
@battermann battermann deleted the SQSERVICES-1643-backend-servantify-brig-account-api-8-onboarding branch September 23, 2022 10:57
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @akshaymankar @fisx @zebot