Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQSERVICES-1643] Servantify brig account API 7 - POST /password-reset/:key #2705

Merged
merged 7 commits into from
Sep 23, 2022
Merged

[SQSERVICES-1643] Servantify brig account API 7 - POST /password-reset/:key #2705

merged 7 commits into from
Sep 23, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Sep 19, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1643

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix September 19, 2022 10:54 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 10:54 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 05b56dc to efb5403 Compare September 19, 2022 10:55
@battermann battermann temporarily deployed to cachix September 19, 2022 10:55 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 10:55 Inactive
@battermann battermann marked this pull request as ready for review September 19, 2022 10:55
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 19, 2022
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from efb5403 to 43c22b6 Compare September 19, 2022 11:01
@battermann battermann temporarily deployed to cachix September 19, 2022 11:01 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:01 Inactive
@battermann battermann requested a review from fisx September 19, 2022 11:01
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 43c22b6 to 152d3e0 Compare September 19, 2022 11:14
@battermann battermann temporarily deployed to cachix September 19, 2022 11:14 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:14 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:27 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:27 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 12:02 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 12:02 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 12:17 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 12:17 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 13:27 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 13:27 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch from 11eff7d to 14b181f Compare September 20, 2022 09:34
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 4ce295f to 3e26053 Compare September 20, 2022 10:29
@battermann battermann temporarily deployed to cachix September 20, 2022 10:29 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 10:29 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 10:49 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 10:49 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 12:29 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 12:29 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch from c7063d6 to a06b3a2 Compare September 22, 2022 14:57
Base automatically changed from SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete to develop September 23, 2022 07:06
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch from 8665f08 to b344410 Compare September 23, 2022 07:09
@battermann battermann temporarily deployed to cachix September 23, 2022 07:09 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 07:09 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 07:14 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 07:14 Inactive
fisx
fisx requested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes in Wire.API.User.Password! But the end-point either needs to be fixed or rolled back. Your call!

libs/wire-api/src/Wire/API/Routes/Public/Brig.hs Outdated
:> CanThrow 'ResetPasswordMustDiffer
:> Description "DEPRECATED: Use 'POST /password-reset/complete'."
:> "password-reset"
:> QueryParam' '[Required, Strict, Description "An opaque key for a pending password reset."] "key" PasswordResetKey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caption, not QueryParam.

Now I'm concerned about there not be any tests that cover this change, though. Maybe better leave this one alone until we remove it?

@battermann battermann temporarily deployed to cachix September 23, 2022 08:26 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 08:26 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 08:36 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 08:36 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 08:38 Inactive
@battermann battermann temporarily deployed to cachix September 23, 2022 08:38 Inactive
@battermann battermann requested a review from fisx September 23, 2022 08:38
@battermann battermann merged commit d23f767 into develop Sep 23, 2022
@battermann battermann deleted the SQSERVICES-1643-backend-servantify-brig-account-api-7-password-reset-key branch September 23, 2022 09:31
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @fisx @zebot