[SQSERVICES-1643] Servantify brig account API 6- POST password-reset/complete
#2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
from
91b97c6 to
0c75ba9
Compare
akshaymankar
requested changes
Sep 19, 2022
Comment on lines
198
to
199
|
|
||
| type instance MapError 'InvalidPwResetCode = 'StaticError 400 "invalid-code" "Invalid password reset code." |
There was a problem hiding this comment.
This is currently only used for swagger, I think we should also use this to create the actually error being thrown, you can use errorToWai. There are examples in the Brig.API.Error module.
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset
branch
from
903a1a0 to
45a8d52
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
from
11eff7d to
14b181f
Compare
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset
branch
from
9ea4c07 to
eb1c446
Compare
Base automatically changed from
SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset
to
develop
September 22, 2022 14:51
battermann
force-pushed
the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
from
c7063d6 to
a06b3a2
Compare
akshaymankar
approved these changes
Sep 22, 2022
battermann
deleted the
SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1643
Checklist
changelog.d