-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQSERVICES-1643] Servantify brig account API 2 - GET /activate
#2700
[SQSERVICES-1643] Servantify brig account API 2 - GET /activate
#2700
Conversation
4e811eb
to
01a355c
Compare
GET /activate
GET /activate
GET /activate
GET /activate
GET /activate
Schema.objectWithDocModifier "ActivationResponse" (description ?~ "Response body of a successful activation request") $ | ||
ActivationResponse | ||
<$> activatedIdentity Schema..= userIdentityObjectSchema | ||
<*> activatedFirst Schema..= (fromMaybe False <$> Schema.optFieldWithDocModifier "first" (description ?~ "Whether this is the first successful activation (i.e. account activation).") Schema.schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<*> activatedFirst Schema..= (fromMaybe False <$> Schema.optFieldWithDocModifier "first" (description ?~ "Whether this is the first successful activation (i.e. account activation).") Schema.schema) | |
<*> activatedFirst Schema..= (fromMaybe False <$> Schema.optFieldWithDocModifier "first" (description ?~ "Whether this is the first successful activation of this account.") Schema.schema) |
(Not sure I understand, though. How often can one account be activated successfully?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from the original swagger documentation. IMO it should not be changed in this PR. Also it is not obvious to me either how this should be phrased correctly.
activateH :: Public.ActivationKey ::: Public.ActivationCode -> (Handler r) Response | ||
activateH (k ::: c) = do | ||
activate :: Public.ActivationKey -> Public.ActivationCode -> (Handler r) ActivationRespWithStatus | ||
activate k c = do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(functionNameH
traditionally means "functionName
, but there is a servant handler with that name, and this is just the wrapper with the wai-route plumbing in it; will be removed once we switch to servant". So it's probably/usually a good idea to merge the two, but yes, in this case I'm not sure how to do that off the top of my head.)
dfdd1d6
to
776df23
Compare
860ab66
to
035d17d
Compare
776df23
to
ea4975a
Compare
added docs for ActivationResponse
ca38058
to
665bb3c
Compare
https://wearezeta.atlassian.net/browse/SQSERVICES-1643
Checklist
changelog.d