Add commit bundle support #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
elland
reviewed
Sep 14, 2022
| let c = newClientId 0x3ae58155 | ||
| usr <- flip Qualified (Domain "example.com") <$> (Id <$> UUID.nextRandom) | ||
| pure (userClientQid usr c) | ||
| void . liftIO $ spawn (cli qcid tmp ["init", qcid]) Nothing |
There was a problem hiding this comment.
Since #2678 was merged, I think we can use that instead, right?
There was a problem hiding this comment.
Unfortunately not, because these changes live in the galley pacakge, not in wire-api
There was a problem hiding this comment.
Should we extract those into their own internal test lib so we can use them across the codebase? @pcapriotti ?
There was a problem hiding this comment.
I'm not to keen on doing this. It's not that much code, anyway, and the unit test setup is much simpler, since we only need to extract one particular message, and not keep track of the state of several clients.
pcapriotti
force-pushed
the
FS-922-post-commit-bundle
branch
from
c51e32f to
140ed67
Compare
pcapriotti
force-pushed
the
FS-922-post-commit-bundle
branch
from
140ed67 to
dd81dc2
Compare
stefanwire
approved these changes
Sep 16, 2022
pcapriotti
force-pushed
the
FS-922-post-commit-bundle
branch
from
27edc9a to
7f17c1f
Compare
The conflict status code 409 should be used for errors that are caused by race conditions, such as in cases where the client has an out-of-date view on the state of the backend.
pcapriotti
force-pushed
the
FS-922-post-commit-bundle
branch
from
7f17c1f to
965d9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.dcharts/nginz/values.yamldeploy/services-demo/conf/nginz/nginx.conf