Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLS: Backend sends remove proposal upon user deletion #2650

Merged
merged 17 commits into from
Sep 1, 2022
Merged

MLS: Backend sends remove proposal upon user deletion #2650

merged 17 commits into from
Sep 1, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Aug 25, 2022 •
edited by pcapriotti
Loading

Send external remove proposals when users are deleted.

Tracked by https://wearezeta.atlassian.net/browse/FS-906.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • I updated changelog.d subsections with one or more entries with the following bits of information (details):

@smatting smatting added the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 25, 2022
@smatting smatting temporarily deployed to cachix August 25, 2022 10:46 Inactive
@smatting smatting temporarily deployed to cachix August 25, 2022 10:46 Inactive
@smatting smatting force-pushed the FS-906-external-remove-proposal branch 3 times, most recently from cc83760 to 7406599 Compare August 25, 2022 16:19
@pcapriotti pcapriotti force-pushed the FS-906-external-remove-proposal branch from 7406599 to b6244be Compare August 26, 2022 08:18
@pcapriotti pcapriotti temporarily deployed to cachix August 26, 2022 08:18 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 26, 2022 08:18 Inactive
@pcapriotti pcapriotti force-pushed the FS-906-external-remove-proposal branch from b6244be to 9603e80 Compare August 26, 2022 10:01
@pcapriotti pcapriotti temporarily deployed to cachix August 26, 2022 10:01 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 26, 2022 10:01 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 14:21 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 14:21 Inactive
@smatting smatting temporarily deployed to cachix August 26, 2022 15:47 Inactive
@smatting smatting temporarily deployed to cachix August 26, 2022 15:47 Inactive
@smatting smatting force-pushed the FS-906-external-remove-proposal branch from 35ce2bc to 79ddc63 Compare August 29, 2022 09:13
@smatting smatting temporarily deployed to cachix August 29, 2022 09:13 Inactive
@smatting smatting temporarily deployed to cachix August 29, 2022 09:13 Inactive
@smatting smatting force-pushed the FS-906-external-remove-proposal branch from 79ddc63 to f9b61a1 Compare August 29, 2022 14:14
@smatting smatting temporarily deployed to cachix August 29, 2022 14:14 Inactive
@smatting smatting temporarily deployed to cachix August 29, 2022 14:14 Inactive
@smatting smatting removed the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 29, 2022
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 29, 2022
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 12:51 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 12:52 Inactive
@pcapriotti pcapriotti force-pushed the FS-906-external-remove-proposal branch from b3ad0d5 to 4307902 Compare August 30, 2022 13:57
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 13:58 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 13:58 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 14:07 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 30, 2022 14:07 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review August 30, 2022 14:07
elland
elland reviewed Aug 31, 2022
View reviewed changes
libs/wire-api/test/unit/Test/Wire/API/MLS.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/Create.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/Federation.hs Show resolved Hide resolved
services/galley/src/Galley/API/Internal.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/MLS/Message.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/MLS/Message.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/MLS/Message.hs Show resolved Hide resolved
@pcapriotti pcapriotti temporarily deployed to cachix August 31, 2022 15:12 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 31, 2022 15:12 Inactive
@smatting smatting temporarily deployed to cachix August 31, 2022 16:18 Inactive
@smatting smatting temporarily deployed to cachix August 31, 2022 16:18 Inactive
@smatting smatting temporarily deployed to cachix September 1, 2022 08:32 Inactive
@smatting smatting temporarily deployed to cachix September 1, 2022 08:32 Inactive
@smatting smatting merged commit 2d3faff into develop Sep 1, 2022
@smatting smatting deleted the FS-906-external-remove-proposal branch September 1, 2022 10:59
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire left review comments

@elland elland elland left review comments

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smatting @pcapriotti @elland @stefanwire @zebot