Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init temp writable uri #2837

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: init temp writable uri #2837

merged 2 commits into from
Mar 28, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 28, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After splitting MessageComposerViewModel I by mistake removed initialisation functions for temp file for camera and video

@Garzas Garzas requested review from yamilmedina and saleniuk March 28, 2024 11:43
@Garzas Garzas self-assigned this Mar 28, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Test Results

878 tests  ±0   878 ✅ ±0   13m 47s ⏱️ + 1m 31s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit 2728037. ± Comparison against base commit bee00f0.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina added this pull request to the merge queue Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (bee00f0) to head (2728037).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2837      +/-   ##
===========================================
+ Coverage    43.78%   43.84%   +0.05%     
===========================================
  Files          422      422              
  Lines        14034    14044      +10     
  Branches      2537     2537              
===========================================
+ Hits          6145     6157      +12     
+ Misses        7169     7167       -2     
  Partials       720      720              
Files Coverage Δ
...conversations/composer/MessageComposerViewModel.kt 76.31% <100.00%> (+3.58%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee00f0...2728037. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 9f6fd8f Mar 28, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the fix/init-temp-uri branch March 28, 2024 13:00
@AndroidBob
Copy link
Collaborator

Build 3832 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants