-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: input is hiding when searching and scrolling [WPB-271] #2826
fix: input is hiding when searching and scrolling [WPB-271] #2826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2826 +/- ##
===========================================
+ Coverage 43.58% 43.63% +0.04%
===========================================
Files 419 419
Lines 14022 14022
Branches 2535 2535
===========================================
+ Hits 6112 6118 +6
+ Misses 7193 7186 -7
- Partials 717 718 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3774 failed. |
…hen-searching-and-scrolling
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3781 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When searching for conversations, users to add or messages, the search input field collapses when scrolling down the results and the “show more” button can not be reached while the keyboard is open.
Solutions
Disable "collapsing" when the search is active - when user is searching and wants to scroll the list then the search input is always visible on top, when user is not searching and search input is inactive, it can collapse when scrolling the list to save space on the screen. Message search screen doesn't need a collapsing scaffold as the search input is always active there.
Testing
How to Test
Search for conversation, for users on conversation creation screen or for messages in a conversation and scroll the list to see how the search input behaves.
Attachments (Optional)
Screen_recording_20240326_173447.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.