Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input is hiding when searching and scrolling [WPB-271] #2826

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 26, 2024

BugWPB-271 [search for users/new conversation flow] user search field should not auto hide while scrolling


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When searching for conversations, users to add or messages, the search input field collapses when scrolling down the results and the “show more” button can not be reached while the keyboard is open.

Solutions

Disable "collapsing" when the search is active - when user is searching and wants to scroll the list then the search input is always visible on top, when user is not searching and search input is inactive, it can collapse when scrolling the list to save space on the screen. Message search screen doesn't need a collapsing scaffold as the search input is always active there.

Testing

How to Test

Search for conversation, for users on conversation creation screen or for messages in a conversation and scroll the list to see how the search input behaves.

Attachments (Optional)

Screen_recording_20240326_173447.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.63%. Comparing base (e79d182) to head (9b1eeb7).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2826      +/-   ##
===========================================
+ Coverage    43.58%   43.63%   +0.04%     
===========================================
  Files          419      419              
  Lines        14022    14022              
  Branches      2535     2535              
===========================================
+ Hits          6112     6118       +6     
+ Misses        7193     7186       -7     
- Partials       717      718       +1     
Files Coverage Δ
...ui/home/conversations/search/SearchPeopleRouter.kt 0.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79d182...9b1eeb7. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Test Results

876 tests  ±0   876 ✅ ±0   14m 25s ⏱️ + 5m 6s
118 suites ±0     0 💤 ±0 
118 files   ±0     0 ❌ ±0 

Results for commit 9b1eeb7. ± Comparison against base commit e79d182.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3774 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3781 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, vitorhugods, mchenani and Garzas and removed request for a team March 27, 2024 09:07
@saleniuk saleniuk added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit de629ad Mar 27, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/hiding-input-when-searching-and-scrolling branch March 27, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants