refactor: remove network from registerToken #WPB-9476

[damian-kaczmarek]

WPB-9476 Add a button in the debug settings screen to re-register the FCM push token with the backend

What's new in this PR?

Issues

removed Suppress and changed function so it doesn't expose network layer

Dependencies (Optional)

Same function is used here #3050
If this PR will be merged before those changes can be applied also there

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 212 tests  ±0   3 106 ✅ ±0   4m 16s ⏱️ +6s
  551 suites ±0     106 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit 66112f3. ± Comparison against base commit 8b65be7.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	refactor/registerToken
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	707,432.24
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	379,218,250.75
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	948,781,299.59
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,650,974.55

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (8b65be7) to head (66112f3).

Files with missing lines	Patch %	Lines
.../wire/kalium/logic/data/client/ClientRepository.kt	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3051      +/-   ##
===========================================
- Coverage    52.50%   52.50%   -0.01%     
===========================================
  Files         1304     1304              
  Lines        50178    50182       +4     
  Branches      4679     4679              
===========================================
+ Hits         26348    26349       +1     
- Misses       21943    21947       +4     
+ Partials      1887     1886       -1     

Files with missing lines	Coverage Δ
...ogic/feature/notificationToken/PushTokenUpdater.kt	94.11% <ø> (ø)
.../wire/kalium/logic/data/client/ClientRepository.kt	44.62% <0.00%> (-1.53%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b65be7...66112f3. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: refactor/registerToken
Commit report: e8131d5
Test service: kalium-jvm

✅ 0 Failed, 3106 Passed, 106 Skipped, 13.26s Total Time

[CLAassistant]

All committers have signed the CLA.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[yamilmedina]

Thanks for taking care of some house cleaning 👏