You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code used to call onError with no argument, which would not emit "error" on the transport itself. Now that an argument is passed, "error" is emitted on the transport. Once this occurs, my logs in syslog immediately stop. Commenting out the offending line (https://github.com/winstonjs/winston-syslog/blob/master/lib/winston-syslog.js#L150) "fixes" it, but I doubt that is the correct approach.
Is there some way to correctly deal with this error and have my log continue working? I can catch the error, but I don't see anything documented in winston for clearing it or really doing anything besides catching it. I also have exitOnError set to false on my main logger.
The text was updated successfully, but these errors were encountered:
Commit db24410 changed the behavior of of
sendDgram
's error handling (seen here: https://github.com/winstonjs/winston-syslog/blob/master/lib/winston-syslog.js#L174).The code used to call
onError
with no argument, which would not emit "error" on the transport itself. Now that an argument is passed, "error" is emitted on the transport. Once this occurs, my logs in syslog immediately stop. Commenting out the offending line (https://github.com/winstonjs/winston-syslog/blob/master/lib/winston-syslog.js#L150) "fixes" it, but I doubt that is the correct approach.Is there some way to correctly deal with this error and have my log continue working? I can catch the error, but I don't see anything documented in winston for clearing it or really doing anything besides catching it. I also have exitOnError set to
false
on my main logger.The text was updated successfully, but these errors were encountered: