Why GeoLite2 placed in %APPDATA%?

[henrypp]

Brief description of your issue

I use portable System Informer, it should placed in application directory!

Steps to reproduce (optional)

No response

Expected behavior (optional)

No response

Actual behavior (optional)

No response

Environment (optional)

SI: every

[Vasilich]

It is placed in app directory if SystemInformer.exe.settings.xml is present in app directory.
How have you configured SI to be portable?

[henrypp]

@Vasilich

ofc, just placed .settings in app directory

[henrypp]

how it confirigure path:

systeminformer/plugins/NetworkTools/country.c

Line 192 in 0815535

dbpath = PhGetApplicationDataFileName(&GeoDbCityFileName, TRUE);

[henrypp]

and there is memory leak:

PPH_STRING PhGetApplicationDirectoryFileName(
    _In_ PCPH_STRINGREF FileName,
    _In_ BOOLEAN NativeFileName
    )
{
    PPH_STRING applicationFileName = NULL;
    PPH_STRING applicationDirectory;

    if (NativeFileName)
        applicationDirectory = PhGetApplicationDirectory();
    else
        applicationDirectory = PhGetApplicationDirectoryWin32();

    if (applicationDirectory)
    {
        applicationFileName = PhConcatStringRef2(&applicationDirectory->sr, FileName);
        PhReferenceObject(applicationDirectory); // THERE IS DEREFERENCE REQUIRED, NOT REFERENCE!
    }

    return applicationFileName;
}