Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Enable/Disable preview panes #29

Closed
mjthoraval opened this issue Oct 14, 2022 · 5 comments
Closed

Enable/Disable preview panes #29

mjthoraval opened this issue Oct 14, 2022 · 5 comments

Comments

@mjthoraval
Copy link

I am a bit confused on what the option "Enable Preview" should be doing in the Zotero Preferences.
image
If I disable this option, the Preview in Info Tab stays there, but keeps the last loaded preview, and does not change anymore when switching items.
If I disable "Enable Preview" and "Preview in Preview Tab", a ghost Preview Tab still remains.

A Zotero restart clears the preview, but both ghost preview panes remain:
image

Should the option "Enable Preview" be a master control of "Preview in Info Tab" & "Preview in Preview Tab"? In that case these two secondary options should be disabled when switching off "Enable Preview".
Or is there another use case for this option?

@windingwind
Copy link
Owner

Fixed in v0.3.3. Currently it requires restarting Zotero to apply.

This option will be removed in the future, as in Zotero 7 all plugins can be disabled without restarting.

@mjthoraval
Copy link
Author

Thank you for your quick replies.
I am still facing some issues: the Preview in Info Tab stays empty, even though it is activated:
image
Restarting does not solve the problem.
The Preview in Preview Tab is working fine for the same PDF file:
image

I get the following error when clicking on a new item seeing the Preview in Info Tab:
[JavaScript Error: "TypeError: iframe is null" {file: "chrome://pdfpreview/content/scripts/index.js" line: 402}]

@volatile-static
Copy link
Contributor

@mjthoraval see #30

@windingwind
Copy link
Owner

fixed.

@mjthoraval
Copy link
Author

Thank you very much for the fix.
I confirm that it is working fine now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants