[Feature] QuickInsert Text of sub-note #174

ynck-codes · 2022-10-09T09:43:04Z

First of all, thank you very much for your fast bug-support🙏🏼

I wonder if there is a way to modify the QuickInsert button behavior. I would rather have the text of the sub-note inserted into the main note instead of a link to the sub-note. I know that I can click onto the link and insert the sub-note as a "linked Note" but that is plenty of work to do when having loads of sub-notes.

Perhaps creating a different button to really quick insert text of sub-note to main-note would do the thing.
It would also be nice if the text updates in main-note when changing the corresponding sub-note.

I may overlook something but is there any chance to realise this kind of behavior?

windingwind · 2022-10-09T12:28:41Z

If you mean this button:

Then absolutely YES!

The link content and style are controlled by the template called "QuickInsert". Please update to the latest and replace it with the text below:

${await new Promise(async (r) => {
  let newLines = [];
  const convertResult = await Zotero.Knowledge4Zotero.NoteUtils.convertNoteLines(
    subNoteItem,
    [],
    true
  );
  const subNoteLines = convertResult.lines;
  // Prevent note to be too long
  if (subNoteLines.join("\n").length > 100000) {
    Zotero.Knowledge4Zotero.ZoteroViews.showProgressWindow(
      "Better Notes",
      "The linked note is too long. Import ignored."
    );
    return;
  }
  const templateText =
    await Zotero.Knowledge4Zotero.TemplateController.renderTemplateAsync(
      "[QuickImport]",
      "subNoteLines, subNoteItem, noteItem",
      [subNoteLines, subNoteItem, noteItem]
    );
  newLines.push(templateText);
  const newLineString = newLines.join("\n");
  const notifyFlag = Zotero.Promise.defer();
  const notifierName = "insertLinkWait";
  Zotero.Knowledge4Zotero.events.addNotifyListener(
    notifierName,
    (event, type, ids, extraData) => {
      if (
        event === "modify" &&
        type === "item" &&
        ids.includes(noteItem.id)
      ) {
        notifyFlag.resolve();
        Zotero.Knowledge4Zotero.events.removeNotifyListener(notifierName);
      }
    }
  );
  await Zotero.Knowledge4Zotero.NoteUtils.modifyLineInNote(
    noteItem,
    (oldLine) => {
      Zotero.debug(oldLine);
      const params = Zotero.Knowledge4Zotero.NoteParse.parseParamsFromLink(link);
      const newLink = !params.ignore
        ? link + (link.includes("?") ? "&ignore=1" : "?ignore=1")
        : link;
      const linkIndex = Zotero.Knowledge4Zotero.NoteParse.parseLinkIndexInText(oldLine);
      Zotero.debug(linkIndex);
      return `${oldLine.slice(0, linkIndex[0])}${newLink}${oldLine.slice(
        linkIndex[1]
      )}\n${newLineString}`;
    },
    lineIndex,
    true
  );
  // wait the first modify finish
  await notifyFlag.promise;
  let hasAttachemnts = false;
  for (const _n of [subNoteItem, ...convertResult.subNotes]) {
    if (Zotero.Items.get(_n.getAttachments()).length) {
      hasAttachemnts = true;
      break;
    }
  }
  if (hasAttachemnts) {
    await Zotero.DB.executeTransaction(async () => {
      await Zotero.Notes.copyEmbeddedImages(subNoteItem, noteItem);
      for (const subNote of convertResult.subNotes) {
        await Zotero.Notes.copyEmbeddedImages(subNote, noteItem);
      }
    });
    await Zotero.Knowledge4Zotero.NoteUtils.scrollWithRefresh(
      Zotero.Knowledge4Zotero.NoteUtils.currentLine[noteItem.id]
    );
  }
})}

It is part of the plugin's code for embedding the linked note content. Be aware the APIs used in this template may change in future releases.

ynck-codes · 2022-10-09T12:54:13Z

Unfortunately the following error appears when clicking the button with changed [QuickInsert] template:

At first glance I cannot find any missing curly braces.

windingwind · 2022-10-09T13:09:26Z

Please check for updates on the plugin page and update plugin to 0.7.8.

ynck-codes · 2022-10-09T13:18:49Z

Awesome, works like a charme. Thank you very much.

ynck-codes · 2022-11-19T10:18:04Z

the provided code snippet does not work anymore.
Could you please help me out?

windingwind · 2022-11-20T03:25:53Z

The API Zotero.Knowledge4Zotero.events is renamed to Zotero.Knowledge4Zotero.ZoteroEvents. Replace it with the new API:

${await new Promise(async (r) => {
  let newLines = [];
  const convertResult = await Zotero.Knowledge4Zotero.NoteUtils.convertNoteLines(
    subNoteItem,
    [],
    true
  );
  const subNoteLines = convertResult.lines;
  // Prevent note to be too long
  if (subNoteLines.join("\n").length > 100000) {
    Zotero.Knowledge4Zotero.ZoteroViews.showProgressWindow(
      "Better Notes",
      "The linked note is too long. Import ignored."
    );
    return;
  }
  const templateText =
    await Zotero.Knowledge4Zotero.TemplateController.renderTemplateAsync(
      "[QuickImport]",
      "subNoteLines, subNoteItem, noteItem",
      [subNoteLines, subNoteItem, noteItem]
    );
  newLines.push(templateText);
  const newLineString = newLines.join("\n");
  const notifyFlag = Zotero.Promise.defer();
  const notifierName = "insertLinkWait";
  Zotero.Knowledge4Zotero.ZoteroEvents.addNotifyListener(
    notifierName,
    (event, type, ids, extraData) => {
      if (
        event === "modify" &&
        type === "item" &&
        ids.includes(noteItem.id)
      ) {
        notifyFlag.resolve();
        Zotero.Knowledge4Zotero.ZoteroEvents.removeNotifyListener(notifierName);
      }
    }
  );
  await Zotero.Knowledge4Zotero.NoteUtils.modifyLineInNote(
    noteItem,
    (oldLine) => {
      Zotero.debug(oldLine);
      const params = Zotero.Knowledge4Zotero.NoteParse.parseParamsFromLink(link);
      const newLink = !params.ignore
        ? link + (link.includes("?") ? "&ignore=1" : "?ignore=1")
        : link;
      const linkIndex = Zotero.Knowledge4Zotero.NoteParse.parseLinkIndexInText(oldLine);
      Zotero.debug(linkIndex);
      return `${oldLine.slice(0, linkIndex[0])}${newLink}${oldLine.slice(
        linkIndex[1]
      )}\n${newLineString}`;
    },
    lineIndex,
    true
  );
  // wait the first modify finish
  await notifyFlag.promise;
  let hasAttachemnts = false;
  for (const _n of [subNoteItem, ...convertResult.subNotes]) {
    if (Zotero.Items.get(_n.getAttachments()).length) {
      hasAttachemnts = true;
      break;
    }
  }
  if (hasAttachemnts) {
    await Zotero.DB.executeTransaction(async () => {
      await Zotero.Notes.copyEmbeddedImages(subNoteItem, noteItem);
      for (const subNote of convertResult.subNotes) {
        await Zotero.Notes.copyEmbeddedImages(subNote, noteItem);
      }
    });
    await Zotero.Knowledge4Zotero.NoteUtils.scrollWithRefresh(
      Zotero.Knowledge4Zotero.NoteUtils.currentLine[noteItem.id]
    );
  }
})}

SYH0323 · 2023-02-16T16:36:56Z

If you mean this button:

Then absolutely YES!

The link content and style are controlled by the template called "QuickInsert". Please update to the latest and replace it with the text below:

${await new Promise(async (r) => {
  let newLines = [];
  const convertResult = await Zotero.Knowledge4Zotero.NoteUtils.convertNoteLines(
    subNoteItem,
    [],
    true
  );
  const subNoteLines = convertResult.lines;
  // Prevent note to be too long
  if (subNoteLines.join("\n").length > 100000) {
    Zotero.Knowledge4Zotero.ZoteroViews.showProgressWindow(
      "Better Notes",
      "The linked note is too long. Import ignored."
    );
    return;
  }
  const templateText =
    await Zotero.Knowledge4Zotero.TemplateController.renderTemplateAsync(
      "[QuickImport]",
      "subNoteLines, subNoteItem, noteItem",
      [subNoteLines, subNoteItem, noteItem]
    );
  newLines.push(templateText);
  const newLineString = newLines.join("\n");
  const notifyFlag = Zotero.Promise.defer();
  const notifierName = "insertLinkWait";
  Zotero.Knowledge4Zotero.events.addNotifyListener(
    notifierName,
    (event, type, ids, extraData) => {
      if (
        event === "modify" &&
        type === "item" &&
        ids.includes(noteItem.id)
      ) {
        notifyFlag.resolve();
        Zotero.Knowledge4Zotero.events.removeNotifyListener(notifierName);
      }
    }
  );
  await Zotero.Knowledge4Zotero.NoteUtils.modifyLineInNote(
    noteItem,
    (oldLine) => {
      Zotero.debug(oldLine);
      const params = Zotero.Knowledge4Zotero.NoteParse.parseParamsFromLink(link);
      const newLink = !params.ignore
        ? link + (link.includes("?") ? "&ignore=1" : "?ignore=1")
        : link;
      const linkIndex = Zotero.Knowledge4Zotero.NoteParse.parseLinkIndexInText(oldLine);
      Zotero.debug(linkIndex);
      return `${oldLine.slice(0, linkIndex[0])}${newLink}${oldLine.slice(
        linkIndex[1]
      )}\n${newLineString}`;
    },
    lineIndex,
    true
  );
  // wait the first modify finish
  await notifyFlag.promise;
  let hasAttachemnts = false;
  for (const _n of [subNoteItem, ...convertResult.subNotes]) {
    if (Zotero.Items.get(_n.getAttachments()).length) {
      hasAttachemnts = true;
      break;
    }
  }
  if (hasAttachemnts) {
    await Zotero.DB.executeTransaction(async () => {
      await Zotero.Notes.copyEmbeddedImages(subNoteItem, noteItem);
      for (const subNote of convertResult.subNotes) {
        await Zotero.Notes.copyEmbeddedImages(subNote, noteItem);
      }
    });
    await Zotero.Knowledge4Zotero.NoteUtils.scrollWithRefresh(
      Zotero.Knowledge4Zotero.NoteUtils.currentLine[noteItem.id]
    );
  }
})}

It is part of the plugin's code for embedding the linked note content. Be aware the APIs used in this template may change in future releases.

大佬，请问这段粘贴到哪里呢？我直接在【编辑】→【模板】那里改quickinsert的代码不行。

windingwind · 2023-02-18T11:27:51Z

Notifier callback registration in Zotero.Knowledge4Zotero.ZoteroEvents is moved to Zotero.Knowledge4Zotero.ZoteroNotifies.

As I stated before, this template uses on inner APIs and you should not rely on it.

${await new Promise(async (r) => {
  let newLines = [];
  const convertResult = await Zotero.Knowledge4Zotero.NoteUtils.convertNoteLines(
    subNoteItem,
    [],
    true
  );
  const subNoteLines = convertResult.lines;
  // Prevent note to be too long
  if (subNoteLines.join("\n").length > 100000) {
    Zotero.Knowledge4Zotero.ZoteroViews.showProgressWindow(
      "Better Notes",
      "The linked note is too long. Import ignored."
    );
    return;
  }
  const templateText =
    await Zotero.Knowledge4Zotero.TemplateController.renderTemplateAsync(
      "[QuickImport]",
      "subNoteLines, subNoteItem, noteItem",
      [subNoteLines, subNoteItem, noteItem]
    );
  newLines.push(templateText);
  const newLineString = newLines.join("\n");
  const notifyFlag = Zotero.Promise.defer();
  const notifierName = "insertLinkWait";
  Zotero.Knowledge4Zotero.ZoteroNotifies.registerNotifyListener(
    notifierName,
    (event, type, ids, extraData) => {
      if (
        event === "modify" &&
        type === "item" &&
        ids.includes(noteItem.id)
      ) {
        notifyFlag.resolve();
        Zotero.Knowledge4Zotero.ZoteroNotifies.unregisterNotifyListener(notifierName);
      }
    }
  );
  await Zotero.Knowledge4Zotero.NoteUtils.modifyLineInNote(
    noteItem,
    (oldLine) => {
      Zotero.debug(oldLine);
      const params = Zotero.Knowledge4Zotero.NoteParse.parseParamsFromLink(link);
      const newLink = !params.ignore
        ? link + (link.includes("?") ? "&ignore=1" : "?ignore=1")
        : link;
      const linkIndex = Zotero.Knowledge4Zotero.NoteParse.parseLinkIndexInText(oldLine);
      Zotero.debug(linkIndex);
      return `${oldLine.slice(0, linkIndex[0])}${newLink}${oldLine.slice(
        linkIndex[1]
      )}\n${newLineString}`;
    },
    lineIndex,
    true
  );
  // wait the first modify finish
  await notifyFlag.promise;
  let hasAttachemnts = false;
  for (const _n of [subNoteItem, ...convertResult.subNotes]) {
    if (Zotero.Items.get(_n.getAttachments()).length) {
      hasAttachemnts = true;
      break;
    }
  }
  if (hasAttachemnts) {
    await Zotero.DB.executeTransaction(async () => {
      await Zotero.Notes.copyEmbeddedImages(subNoteItem, noteItem);
      for (const subNote of convertResult.subNotes) {
        await Zotero.Notes.copyEmbeddedImages(subNote, noteItem);
      }
    });
    await Zotero.Knowledge4Zotero.NoteUtils.scrollWithRefresh(
      Zotero.Knowledge4Zotero.NoteUtils.currentLine[noteItem.id]
    );
  }
})}

GouPengyun · 2023-02-26T07:56:07Z

现在这个方法插入几次笔记之后主笔记的文档层次就会被搞乱。原本设置的一级标题会莫名其妙的被变成引用的内容，如图。

ynck-codes added the enhancement New feature or request label Oct 9, 2022

windingwind closed this as completed Oct 9, 2022

SYH0323 mentioned this issue Feb 17, 2023

快速插入(quickinsert)：能否直接插入子笔记的正文到主笔记，而不是子笔记的链接？ #365

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] QuickInsert Text of sub-note #174

[Feature] QuickInsert Text of sub-note #174

ynck-codes commented Oct 9, 2022

windingwind commented Oct 9, 2022

ynck-codes commented Oct 9, 2022

windingwind commented Oct 9, 2022 •

edited

Loading

ynck-codes commented Oct 9, 2022

ynck-codes commented Nov 19, 2022

windingwind commented Nov 20, 2022

SYH0323 commented Feb 16, 2023

windingwind commented Feb 18, 2023

GouPengyun commented Feb 26, 2023

[Feature] QuickInsert Text of sub-note #174

[Feature] QuickInsert Text of sub-note #174

Comments

ynck-codes commented Oct 9, 2022

windingwind commented Oct 9, 2022

ynck-codes commented Oct 9, 2022

windingwind commented Oct 9, 2022 • edited Loading

ynck-codes commented Oct 9, 2022

ynck-codes commented Nov 19, 2022

windingwind commented Nov 20, 2022

SYH0323 commented Feb 16, 2023

windingwind commented Feb 18, 2023

GouPengyun commented Feb 26, 2023

windingwind commented Oct 9, 2022 •

edited

Loading