fix: menuitem checkbox icon

windingwind · Nov 18, 2024 · c3ab5c4 · c3ab5c4
1 parent 541046d
commit c3ab5c4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
     "update-deps": "npm update --save"
   },
   "dependencies": {
-    "zotero-plugin-toolkit": "^4.0.10"
+    "zotero-plugin-toolkit": "^4.0.11"
   },
   "devDependencies": {
     "@eslint/js": "^9.14.0",

diff --git a/src/modules/menu.ts b/src/modules/menu.ts
@@ -16,16 +16,16 @@ function initMenus(win: _ZoteroTypes.MainWindow): void {
     id: `${addon.data.config.addonRef}-menu-view-enable-bionic`,
     classList: ["menu-type-reader", "pdf"],
     label: getString("menu-enableBionic"),
+    type: "checkbox",
     commandListener: () => {
       setPref("enableBionicReader", !getPref("enableBionicReader"));
     },
     getVisibility(elem, ev) {
-      elem.setAttribute("type", "checkbox");
       elem.setAttribute(
         "checked",
         getPref("enableBionicReader") ? "true" : "false",
       );
-      return !elem.hidden;
+      return undefined;
     },
   });
 
@@ -34,6 +34,7 @@ function initMenus(win: _ZoteroTypes.MainWindow): void {
     id: `${addon.data.config.addonRef}-menu-view-enable-bionic-current-item`,
     classList: ["menu-type-reader", "pdf"],
     label: getString("menu-enableBionicForCurrentItem"),
+    type: "checkbox",
     commandListener: () => {
       const itemID = Zotero.Reader.getByTabID(
         win.Zotero_Tabs.selectedID,
@@ -44,7 +45,6 @@ function initMenus(win: _ZoteroTypes.MainWindow): void {
       toggleCurrentItemStatus(itemID);
     },
     getVisibility(elem, ev) {
-      elem.setAttribute("type", "checkbox");
       const itemID = Zotero.Reader.getByTabID(
         win.Zotero_Tabs.selectedID,
       ).itemID;
@@ -55,7 +55,7 @@ function initMenus(win: _ZoteroTypes.MainWindow): void {
         "checked",
         getCurrentItemStatus(itemID) ? "true" : "false",
       );
-      return !elem.hidden;
+      return undefined;
     },
   });