Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove annotation support for HX-Refresh, HX-Location and HX-Redirect #154

Open
xhaggi opened this issue Nov 25, 2024 · 3 comments
Open
Labels
Discussion Something that is under discussion

Comments

@xhaggi
Copy link
Collaborator

xhaggi commented Nov 25, 2024

I would like to discuss whether we should drop the annotations @HxRefresh, @HxLocation and @HxRedirect, as it makes no sense to me to use them in a controller method in combination with a view as a return value. This would also simplify our code base and make things less confusing.

@wimdeblauwe what do you think?

@xhaggi xhaggi added the Discussion Something that is under discussion label Nov 25, 2024
@wimdeblauwe
Copy link
Owner

Can you add an examples of how the code looks with the annotations and without? I will add a message on Twitter and Bluesky after that so people can give their opinion on this.

@Alwan
Copy link

Alwan commented Nov 30, 2024

Spring MVC support special prefix like "redirect:/"
Maybe return a string "hx:refresh"

@resmo
Copy link

resmo commented Dec 2, 2024

I would like to discuss whether we should drop the annotations @HxRefresh, @HxLocation and @HxRedirect, as it makes no sense to me to use them in a controller method in combination with a view as a return value. This would also simplify our code base and make things less confusing.

I don't use these as I don't see a use case as a controller annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Something that is under discussion
Projects
None yet
Development

No branches or pull requests

4 participants