Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add package [sparkline] add support for tooltips #72

Merged
merged 8 commits into from
Nov 3, 2017
Merged

[core] add package [sparkline] add support for tooltips #72

merged 8 commits into from
Nov 3, 2017

Conversation

williaster
Copy link
Owner

@williaster williaster commented Nov 1, 2017 •
edited
Loading

This PR adds

  • support for tooltips in @data-ui/sparkline (with render cascade perf improvements such as PureComponent)
  • factors out WithTooltip from all packages into a new @data-ui/core @data-ui/shared package for current/future shared code

sparkline-tooltip-2

sparkline-tooltips

sparkline-tooltip-crosshair

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 76.334% when pulling 6b64209 on chris--sparkline-tooltip into 74e88a2 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 1, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-8.6%) to 76.334% when pulling 6b64209 on chris--sparkline-tooltip into 74e88a2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.6%) to 76.334% when pulling 77cc9cb on chris--sparkline-tooltip into 74e88a2 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-8.6%) to 76.334% when pulling 77cc9cb on chris--sparkline-tooltip into 74e88a2 on master.

@williaster williaster force-pushed the chris--sparkline-tooltip branch from 77cc9cb to 62f303f Compare November 3, 2017 02:35
@coveralls
Copy link

coveralls commented Nov 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-8.3%) to 76.389% when pulling 62f303f on chris--sparkline-tooltip into 4c8bdd8 on master.

@coveralls
Copy link

coveralls commented Nov 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 83.927% when pulling 485eeba on chris--sparkline-tooltip into 4c8bdd8 on master.

@williaster
Copy link
Owner Author

publishing should fix the build

@coveralls
Copy link

coveralls commented Nov 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.7%) to 83.023% when pulling 340cee0 on chris--sparkline-tooltip into 4c8bdd8 on master.

@williaster williaster merged commit b0e301a into master Nov 3, 2017
@williaster williaster deleted the chris--sparkline-tooltip branch November 3, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williaster @coveralls