-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bash-debug-adapter): add bash-debug-adapter #253
feat(bash-debug-adapter): add bash-debug-adapter #253
Conversation
Hi. Just thought I'd add bash debug adapter to the mix as it was missing. Let me know if anything else needs adding, or if you'd prefer I also raise an issue and link it to this PR |
- php installer was still referenced - updated to use correct bash github repo
OK. So I just realised that trying to unzip the release file doesn't work quite as expected due to the release of some untagged versions of the debugger (i.e. https://github.com/rogalmic/vscode-bash-debug/releases/download/untagged-438733f35feb8659d939/bash-debug-0.3.9.vsix). So mason is looking for the vsix file using the wrong URL with the current code. I think my one successful download might have been a red herring. I'm not sure if installing using npm compile script (which is how I've installed it in the past) is viable for this, or how to fix the unusually formed URL that mason attempt to download from. In addition, the vscode-bash-debug adapter hasn't been updated for a long while, which makes me wonder if this is still the best way to debug shell scripts in neovim! |
Ah yeah that's annoying. In this case we'll have to interface directly with the GitHub client to fetch release data and extract the first suitable asset file (like test against |
@williambotman /fixup |
Nice @williamboman ! Out of interest, the 'languages' list on the package, and the subsequent language mappings that are added are for typescript and JavaScript. Am I correct in assuming that these mapping refer to the languages that the package itself was written in? |
Tested locally using WSL on Ubuntu 20.04