Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bash-debug-adapter): add bash-debug-adapter #253

Merged
merged 7 commits into from
Aug 5, 2022
Merged

feat(bash-debug-adapter): add bash-debug-adapter #253

merged 7 commits into from
Aug 5, 2022

Conversation

Issafalcon
Copy link
Contributor

Tested locally using WSL on Ubuntu 20.04

  • Installs the bash debug adapter with no errors
  • Not entirely sure if I'm missing anything as I copied code from other examples of debug adapter install features

@Issafalcon
Copy link
Contributor Author

Hi. Just thought I'd add bash debug adapter to the mix as it was missing. Let me know if anything else needs adding, or if you'd prefer I also raise an issue and link it to this PR

Adam Figgins added 2 commits August 5, 2022 17:22
- php installer was still referenced
- updated to use correct bash github repo
@Issafalcon
Copy link
Contributor Author

OK. So I just realised that trying to unzip the release file doesn't work quite as expected due to the release of some untagged versions of the debugger (i.e. https://github.com/rogalmic/vscode-bash-debug/releases/download/untagged-438733f35feb8659d939/bash-debug-0.3.9.vsix). So mason is looking for the vsix file using the wrong URL with the current code. I think my one successful download might have been a red herring.

I'm not sure if installing using npm compile script (which is how I've installed it in the past) is viable for this, or how to fix the unusually formed URL that mason attempt to download from. In addition, the vscode-bash-debug adapter hasn't been updated for a long while, which makes me wonder if this is still the best way to debug shell scripts in neovim!

@williamboman
Copy link
Owner

williamboman commented Aug 5, 2022

OK. So I just realised that trying to unzip the release file doesn't work quite as expected due to the release of some untagged versions of the debugger (i.e. https://github.com/rogalmic/vscode-bash-debug/releases/download/untagged-438733f35feb8659d939/bash-debug-0.3.9.vsix). So mason is looking for the vsix file using the wrong URL with the current code. I think my one successful download might have been a red herring.

Ah yeah that's annoying. In this case we'll have to interface directly with the GitHub client to fetch release data and extract the first suitable asset file (like test against %.vsix$). This would have to be done while respecting ctx.requested_version (if empty the latest release should be used). I'll see if I can add something to the PR

@williamboman
Copy link
Owner

@williambotman /fixup

@williamboman williamboman merged commit cfa56f1 into williamboman:main Aug 5, 2022
@Issafalcon
Copy link
Contributor Author

Nice @williamboman ! Out of interest, the 'languages' list on the package, and the subsequent language mappings that are added are for typescript and JavaScript. Am I correct in assuming that these mapping refer to the languages that the package itself was written in?

vantaboard pushed a commit to vantaboard/mason.nvim that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants