feat: add tectonic #249
Merged
feat: add tectonic #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @thanhvule0310! Thanks for the PR, looks great as always. I’m not too sure about this package though, see my comment #248 (comment). As you also mention, this doesn’t seem to fit any category. Let’s see what Raafat says. |
williamboman
approved these changes
Aug 5, 2022
williamboman
reviewed
Aug 5, 2022
| github | ||
| .unzip_release_file({ | ||
| repo = repo, | ||
| asset_file = format_release_file "tectonic-%s-x86_64-pc-windows-msvc.zip", |
There was a problem hiding this comment.
Changing Windows to use the binary built using the MSVC toolchain (instead of GNU which use the GNU ABI).
Comment on lines
+34
to
+37
| when( | ||
| platform.is.linux_x64 and platform.get_libc() == "musl", | ||
| format_release_file "tectonic-%s-x86_64-unknown-linux-musl.tar.gz" | ||
| ), |
There was a problem hiding this comment.
Making sure to install correct binary on musl systems
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved issue #248 . However I don't use tectonic, so I'm not sure what category it is. 🤔