-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature smooth exit #62
Open
LeoGuillon
wants to merge
21
commits into
will8211:MTRX-3-revise-defaults
Choose a base branch
from
LeoGuillon:feature-smooth_exit
base: MTRX-3-revise-defaults
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature smooth exit #62
LeoGuillon
wants to merge
21
commits into
will8211:MTRX-3-revise-defaults
from
LeoGuillon:feature-smooth_exit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long arguments '--custom-characters' and '--single-wave' were previously written as '--custom_characters' and '--single_wave', which didn't work, because they are parsed with hyphens, not underscores.
Change underscores to hyphens in some args in help msg.
ch: rename from avrahambenaram to will8211
README.md: add section to install without sudo
Support all systems
Resolves warning messages and adds backslash as character
Fix invalid escape sequence warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new parameter with
smooth-exit
, allowing the process to exit smoothly (similarly to single_wave mode) when the time runs to 0 or exiting with space or q. Esc stills insta quit the process.