[WFCORE-7064] Do not set SM options on JDK24+

[ropalka]

https://issues.redhat.com/browse/WFCORE-7064

[bstansberry]

The test changes look good, but I'm wondering about the production code changes.

We don't want to be setting -Djava.security.manager=allow on our own on SE 24+, but that would be done in things like the scripts or the launcher. The code here seems to be about processing external input. (It may be input that's been through various layers and transformations, but ultimately it's derived from external input.) If we get input to enable the SM, I don't think we should ignore it on 24; we should process it and let things fail.

[wildfly-ci]

Core -> Full Integration Build 14053 outcome was FAILURE using a merge of dc30e56
Summary: Tests failed: 1 (1 new), passed: 3973, ignored: 62 Build time: 02:39:20

Failed tests

org.jboss.as.test.clustering.cluster.ejb.timer.DistributedTimerServiceTestCase.test: java.lang.AssertionError: class org.jboss.as.test.clustering.cluster.ejb.timer.beans.IntervalPersistentTimerBean={node-1=[]}. Actual: 0
	at org.jboss.as.test.clustering.cluster.ejb.timer.AbstractTimerServiceTestCase.test(AbstractTimerServiceTestCase.java:305)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
------- Stdout: -------
node-2 2024-11-22 00:20:32,802 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.5.Final
node-2 2024-11-22 00:20:33,693 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.5.Final
node-2 2024-11-22 00:20:33,705 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
node-2 2024-11-22 00:20:33,820 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly 35.0.0.Beta1-SNAPSHOT (WildFly Core 27.0.0.Beta4-SNAPSHOT) starting
node-2 2024-11-22 00:20:35,340 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.6.0.Final
node-2 2024-11-22 00:20:36,329 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
node-2 2024-11-22 00:20:36,349 INFO  [org.xnio] (MSC service thread 1-3) XNIO version 3.8.16.Final
node-2 2024-11-22 00:20:36,355 INFO  [org.xnio.nio] (MSC service thread 1-3) XNIO NIO Implementation Version 3.8.16.Final
node-2 2024-11-22 00:20:36,394 INFO  [org.jboss.remoting] (MSC service thread 1-3) JBoss Remoting version 5.0.30.Final
node-2 2024-11-22 00:20:36,439 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 40) WFLYCLINF0001: Activating Infinispan subsystem.
node-2 2024-11-22 00:20:36,456 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 42) WFLYRS0016: RESTEasy version 6.2.11.Final
node-2 2024-11-22 00:20:36,491 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 32) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 2.2)
node-2 2024-11-22 00:20:36,496 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 41) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
node-2 2024-11-22 00:20:36,501 INFO  [org.jboss.as.connector] (MSC service thread 1-5) WFLYJCA0009: Starting Jakarta Connectors Subsystem (WildFly/IronJacamar 3.0.10.Final)
node-2 2024-11-22 00:20:36,519 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 48) WFLYNAM0001: Activating Naming Subsystem
node-2 2024-11-22 00:20:36,523 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 44) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 5.2.29
node-2 2024-11-22 00:20:36,541 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-8) WFLYJCA0018: Started Driver service with driver-name = h2
node-2 2024-11-22 00:20:36,560 INFO  [org.jboss.as.naming] (MSC service thread 1-7) WFLYNAM0003: Starting Naming Service
node-2 2024-11-22 00:20:36,575 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 53) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
node-2 2024-11-22 00:20:36,677 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-7) WFLYELY00023: KeyStore file '/opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-ejb-2/standalone/configuration/application.keystore' does not exist. Used blank.
node-2 2024-11-22 00:20:36,746 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-4) WFLYELY01084: KeyStore /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-ejb-2/standalone/configuration/application.keystore not found, it will be auto-generated on first use with a self-signed certificate for host localhost
node-2 2024-11-22 00:20:36,765 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0003: Undertow 2.3.18.Final starting
node-2 2024-11-22 00:20:36,890 INFO  [org.jboss.as.ejb3] (MSC service thread 1-2) WFLYEJB0481: Strict pool slsb-strict-max-pool is using a max instance size of 64 (per class), which is derived from thread worker pool sizing.
node-2 2024-11-22 00:20:36,891 INFO  [org.jboss.as.ejb3] (MSC service thread 1-1) WFLYEJB0482: Strict pool mdb-strict-max-pool is using a max instance size of 16 (per class), which is derived from the number of CPUs on this host.
node-2 2024-11-22 00:20:36,969 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) WFLYUT0012: Started server default-server.
node-2 2024-11-22 00:20:36,985 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) Queuing requests.
node-2 2024-11-22 00:20:36,986 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) WFLYUT0018: Host default-host starting
node-2 2024-11-22 00:20:37,118 WARN  [org.jboss.as.domain.http.api.undertow] (MSC service thread 1-4) WFLYDMHTTP0003: Unable to load console module for slot main, disabling console
node-2 2024-11-22 00:20:37,131 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-2) WFLYUT0006: Undertow HTTP listener default listening on [::1]:8180
node-2 2024-11-22 00:20:37,246 INFO  [org.jboss.as.ejb3] (MSC service thread 1-1) WFLYEJB0493: Jakarta Enterprise Beans subsystem suspension complete
node-2 2024-11-22 00:20:37,311 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-8) WFLYJCA0001: Bound data source [java:jboss/datasources/ExampleDS]
node-2 2024-11-22 00:20:37,371 INFO  [org.jboss.as.server.deployment.scanner] (MSC service thread 1-4) WFLYDS0013: Started FileSystemDeploymentService for directory /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-ejb-2/standalone/deployments
node-2 2024-11-22 00:20:37,489 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
node-2 2024-11-22 00:20:37,496 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:10090/management
node-2 2024-11-22 00:20:37,496 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled
node-2 2024-11-22 00:20:37,497 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly 35.0.0.Beta1-SNAPSHOT (WildFly Core 27.0.0.Beta4-SNAPSHOT) started in 5352ms - Started 287 of 661 services (449 services are lazy, passive or on-demand) - Server configuration file in use: standalone-full-ha.xml - Minimum feature stability level: community

[ropalka]

Thinking about it you are of course right @bstansberry ! I updated PR to include only test suite changes.

[bstansberry]

Thanks, @ropalka!