-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELYEE-44] Update CI to also run with JDK 21 #29
Conversation
.github/workflows/pr-ci.yaml
Outdated
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest, macos-latest] | ||
java: ['11', '21'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added JDK 17.
Strange, we seem to have an issue with being able to run these jobs. Something similar also happened for our other projects: e.g., @PrarthonaPaul Would you have some time to take a closer look at the jobs to see if we can get them running successfully? Some examples of other projects that are running successfully with multiple JDK versions can be found here: https://github.com/wildfly/galleon/blob/main/.github/workflows/ci.yml Looking at those examples, they aren't including macos runners so we maybe we need to limit to just JDK 11 for macos or perhaps there's something else in our config that we're missing or need to tweak. |
Its odd, the other projects' CI does not have any reasons listed for why the CI is failing. It just says "The Job Failed" when you go on details. |
The |
Superseded by #32. Thanks very much @PrarthonaPaul! |
https://issues.redhat.com/browse/ELYEE-44
https://issues.redhat.com/browse/ELYEE-45