Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELYEE-44] Update CI to also run with JDK 21 #29

Merged
merged 2 commits into from
May 6, 2024

Conversation

fjuma
Copy link
Contributor

@fjuma fjuma commented Mar 14, 2024

@fjuma fjuma requested review from Skyllarr and ivassile March 14, 2024 18:50
@ivassile ivassile added the +1 IV label Mar 14, 2024
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
java: ['11', '21']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added JDK 17.

@fjuma
Copy link
Contributor Author

fjuma commented May 3, 2024

Strange, we seem to have an issue with being able to run these jobs. Something similar also happened for our other projects:

e.g.,
wildfly-security/elytron-web#250
wildfly-security/wildfly-openssl#136

@PrarthonaPaul Would you have some time to take a closer look at the jobs to see if we can get them running successfully? Some examples of other projects that are running successfully with multiple JDK versions can be found here:

https://github.com/wildfly/galleon/blob/main/.github/workflows/ci.yml
https://github.com/wildfly/wildfly-client-config/blob/main/.github/workflows/ci.yml

Looking at those examples, they aren't including macos runners so we maybe we need to limit to just JDK 11 for macos or perhaps there's something else in our config that we're missing or need to tweak.

@PrarthonaPaul
Copy link
Contributor

PrarthonaPaul commented May 3, 2024

Its odd, the other projects' CI does not have any reasons listed for why the CI is failing. It just says "The Job Failed" when you go on details.
It could be because of os: [ubuntu-latest, windows-latest, macos-latest ] where the other projects are not including MacOS.
Also, I noticed this file has
runs-on: ${{ matrix.os }}-jdk${{ matrix.java }}
while the wildfly has
name: ${{ matrix.os }}-jdk${{ matrix.java }} runs-on: ${{ matrix.os }}
Could that be something?

@fjuma
Copy link
Contributor Author

fjuma commented May 3, 2024

The name determines how the the CI job will be listed in the output (e.g., see wildfly/wildfly-client-config#46). The runs-on defines the machine the job should be run on (e.g., linux, etc.) so any differences there could be good things to look at.

@fjuma fjuma mentioned this pull request May 3, 2024
@fjuma fjuma merged commit 54f887b into wildfly-security:3.x May 6, 2024
0 of 9 checks passed
@fjuma
Copy link
Contributor Author

fjuma commented May 6, 2024

Superseded by #32. Thanks very much @PrarthonaPaul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants