Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider no-animate-shorthand aggregate rule #36

Open
edg2s opened this issue Dec 17, 2018 · 2 comments
Open

Consider no-animate-shorthand aggregate rule #36

edg2s opened this issue Dec 17, 2018 · 2 comments

Comments

@edg2s
Copy link
Member

edg2s commented Dec 17, 2018

Following on from #33:

These set of rules are now covered by:

  • no-fade
  • no-slide
  • no-animate-toggle
  • no-animate

Arguably the first two or three could be combined into a no-animate-shorthand/shortcut rule, but for now we have covered all the ways to call $.animate.

@edg2s
Copy link
Member Author

edg2s commented Feb 20, 2019

We should probably avoid aggregate rules, and deprecate our existing ones (no-each = no-each-util + no-each-collection). If we really need to group rules we should create shared rulesets (c.f. deprecated ruleset)

@jdforrester
Copy link
Member

We should probably […] deprecate our existing ones (no-each = no-each-util + no-each-collection).

Should we do this? (How?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants