-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppBar doesnt show with just Tabs as content #634
Comments
Hey @Jhsmit! This happens because the tabs are the only child to the appbar. What determines whether the appbar gets shown in the Solara code is solara/solara/components/applayout.py Line 260 in 65a0cfc
So in your case this takes the value children_appbar , which only has the tabs in it. However later on tabs get taken out of the children_appbar , since they have to be treated specially. solara/solara/components/applayout.py Lines 275 to 280 in 65a0cfc
This makes show_app_bar evaluate as False when we want to render it. There was another issue (#584) related to the appbar. I think this week I should take a look at the logic there to see if it can be improved a little bit.
In the meantime, if you need a workaround, defining the tabs by using routing might be a workaround. |
This was fixed in #656 |
shows as:
![image](https://private-user-images.githubusercontent.com/7881506/328540108-ad81a69f-024a-43e5-90bd-bb6fc7307620.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTIzOTksIm5iZiI6MTczOTU1MjA5OSwicGF0aCI6Ii83ODgxNTA2LzMyODU0MDEwOC1hZDgxYTY5Zi0wMjRhLTQzZTUtOTBiZC1iYjZmYzczMDc2MjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTY1NDU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDEyOTNiMWZlOWY1YjU2YTM5MjExYzdkYTY5ZjdjMWI5N2IxNGVjNmM2ZmM0MmRhMzIyMTdkYWQ2OTgwYTAxZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.MNYXab94El0RXIdDm5gr_rcU5KYGK4_QcexXEo_IVes)
with button uncommented:
![image](https://private-user-images.githubusercontent.com/7881506/328540236-71362d8f-f5e3-4a58-9e35-8a738b19d036.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTIzOTksIm5iZiI6MTczOTU1MjA5OSwicGF0aCI6Ii83ODgxNTA2LzMyODU0MDIzNi03MTM2MmQ4Zi1mNWUzLTRhNTgtOWUzNS04YTczOGIxOWQwMzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTY1NDU5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDQyMmMyMWJlYjZlOWJlMzhiOTBjNmQxMDBkOTJjZDNjYjAwOTA3YTNjZjVkMmRjOTNjNDM0MGU3Yjg0OWI4OCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.jPuwJKrWnl8TzxDAqpbvmjiAic4O1nR49vCyJ7vz-IY)
The text was updated successfully, but these errors were encountered: