-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untested code in fastani.py
#405
Comments
Upon further investigation, the flagged lines are redundant, sort of.
So, the |
fastani.py
fastani.py
Summary:
Lines 97–99 in
pyani/fastani.py
:are missed by testing, and likely redundant.
fastani_path
is defined a few lines before, within atry/except
block; were this to raise something other than aTypeError
(thus leavingfastani_path
unassigned), which is handled with a logging statement, the program would still exit before lines 97–99 were run.Commenting out these lines causes no tests to fail. Whereas commenting out lines 93–96, causes
test_get_version_nonetype()
frompyani/tests/test_fastani.py
to fail.pyani Version:
pyani version: 0.3.0-alpha
installed dependencies
If you are running a version of
pyani
v0.3 or later, then please run the commandpyani listdeps
at the command line, and enter the output below.Python Version:
3.8.12
Operating System:
macOS High Sierra
The text was updated successfully, but these errors were encountered: