Resource Details view fails to load in Nova 4.32.13 and up

[ryandrobinson]

Tested in Laravel Nova 4.32.13 and 4.32.15:

Loading a Nova Resource Details screen that has a Flexible field causes the Chrome tab to lock up. No exceptions are logged, and no console errors are shown.

The latest version of Nova I've found to work properly with this package is 4.32.11

[jmverges]

@ryandrobinson happy to see I'm not the only one.

[PimButton]

We also have this problem!

[LTKort]

@ryandrobinson Does the amount of layouts / presets and/or models have any effect?
We’ve tried with 2 pages and 6 layouts and everything seems to work, but with bigger projects it breaks.
When looking into the changes of Nova, not a lot of ‘real’ logic has changed.

[justindantzer]

@LTKort Locally I'm testing with a single layout, containing 2 fields, and have the same issue noted by @ryandrobinson.

Can confirm version Nova 4.32.11 is functional with Flexible fields.

[bracketsdigital]

same issues here :(

[aurelien-ci]

I have the same problem : we can create the ressource but then its impossible to open edit page, even if the fields or the layout is empty (with nova 4.32.14, nova-flexible-content 1.0.14)

[SchwartzN]

Same issue as @aurelien-ci

[bracketsdigital]

We seem to be okay if we update our composer.json file to specify the previous release:
"whitecube/nova-flexible-content": "1.0.13"
..then run:
composer update --prefer-dist

[alekmlynek]

Have this same issue. Client reported it to me after creating a "resource" then having it freeze up. It seems like a JS issue, the browser asks to terminate the script that is run on infinite loop.

As a terrible bandaid, I've advised them to use the "Update and Continue Editing" function and then manually exit the resource.

[chrispage1]

Yep, exactly the same issue here.

It's worth noting this does seem specific to a Nova update as keeping the same flexible content package and upgrading Nova causes the problem. For now I've reverted to our last known working Nova version 4.27.12

[mateusgalasso]

same error here

[ArtDepartmentMJ]

Same 😟

[pazazdigital]

Hey whitecube, very happy to pay you for you to resolve this asap. Let us know. :)

[voidgraphics]

We seem to be okay if we update our composer.json file to specify the previous release: "whitecube/nova-flexible-content": "1.0.13" ..then run: composer update --prefer-dist

If this is the case, it means the bug comes from #490 which is the only change there was in that version. Admittedly, I merged it without testing, as I had neither the time nor the necessary license, and the comments on it seemed to indicate it was functional. I apologise for the trouble.

The license being a problem, I can not fix this right now, and I need to discuss a possible renewal with @toonvandenbos before I do anything. It's the week-end right now, so I will ask for your patience until monday. I believe in the mean time you can force version 1.0.13 of this package to fix the problem.

Hey whitecube, very happy to pay you for you to resolve this asap. Let us know. :)

That's very kind, thank you. We always appreciate sponsorships. If you're rather thinking about a one-time contribution to help us get this particular issue sorted, you can contact me by e-mail at [email protected] and I'll make sure the boss hears about it so we can dedicate some time for this asap!

In any case, if anyone else wants to have a go at a PR, that would work too and I'll be sure to get it merged quickly (although without testing it first, again, as I have no access to a license right now).

Also a reminder that we are looking for someone who regularly uses this package and would be willing to help us maintain it. If anyone is interested, feel free to send me an e-mail about this as well.

[LTKort]

@voidgraphics I reverted #490 in #509

[LTKort]

Okay, I think I found the issue, the layout attribute keys were all being loaded and looped.
So there were some extreme long strings, and layouts were being loaded that should not load.

I pushed my fix on #509. Is there anyone who could verify this works?

---

To test or use these changes, temporarily add my fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/ltkort/nova-flexible-content.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "whitecube/nova-flexible-content": "dev-l11-compatibility",
    }
}

Finally, run: composer update

[Jon78]

I pushed my fix on #509. Is there anyone who could verify this works?

Good find. Works!

[daanadriaan]

I pushed my fix on #509. Is there anyone who could verify this works?

Works!

[voidgraphics]

Please upgrade to v1.1.0 for L11 compatibility and a revert of the problematic PR which caused this error.