We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TryFrom<EnvelopeEntity> for Envelope
I came across this while implementing #255
match entity.source_uuid.as_deref() { Some(uuid) => { let address = uuid.try_into()?; Ok(Envelope::new_with_source(entity, address)) }, None => Ok(Envelope::new_from_entity(entity)), }
I'm not sure why we don't handle the address in a single new constructor.
address
new
Additionally, the initialization in new_from_entity contains this funny part:
new_from_entity
server_guid: entity.source_uuid,
Git blame comes to me, so I did that. Not sure why.
We should probably revisit the whole logic here and adopt it anew from Android/SD's logic.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I came across this while implementing #255
I'm not sure why we don't handle the
address
in a singlenew
constructor.Additionally, the initialization in
new_from_entity
contains this funny part:Git blame comes to me, so I did that. Not sure why.
We should probably revisit the whole logic here and adopt it anew from Android/SD's logic.
The text was updated successfully, but these errors were encountered: