Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print output directory #393

Closed
srussel opened this issue Mar 28, 2019 · 2 comments
Closed

Always print output directory #393

srussel opened this issue Mar 28, 2019 · 2 comments
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Improvement Minor improvement to code

Comments

@srussel
Copy link

srussel commented Mar 28, 2019

I have a script that that runs whipper cd rip then fetches the artwork. The script needs to know the output directory created. I have tried parsing the whipper output for the INFO:whipper.command.cd:creating output directory ... output. The problem is this does not always work. It seems that if I rip a new disc, the directory is created by the ripTrack function in program.py. If I rip a disc I have previously ripped (and deleted the previous rip output) the directory is created in cd.py and I get the creating output directory log.

I couldn't figure out how the different code paths are reached but it would be nice if in either case the same creating output directory log is generated so scripts can extract the output directory.

@srussel
Copy link
Author

srussel commented Mar 28, 2019

I tried adding the creating output directory log statement to the os.makedirs(dirname) in program.py and I still don't get that output in every rip.

Maybe whipper could just print a "using output dir ..." or for every rip. Or print the full path to the log file. Something that a script can parse to get the output dir.

@srussel
Copy link
Author

srussel commented Mar 28, 2019

I found it. The makedirs in cdrdao.py is sometimes executed first.

@JoeLametta JoeLametta added Design Design or UX/UI related On Hold Waiting for other actions labels Dec 26, 2020
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Improvement Minor improvement to code and removed On Hold Waiting for other actions labels May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants