-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
musicbrainz calculation fails on cd with data tracks that are not positioned at the end #289
Comments
The issue here is that morituri's own "musicbrainz id calculation" fails on CDs with data tracks on special places. For my IA fork I decided it wasn't worth my time fixing the custom calculation, and instead I added this commit: https://git.archive.org/archivecd/morituri/commit/8e108e239b15600315128b2e0cba0d4836f044d7 and set the value using the defacto discid library, which does get it right. We probably do not want to use this hack, but I'm all for just throwing out the custom calculation code from morituri in favour of libdiscid. |
👍 |
@MerlijnWajer that repository is gone - is there a copy anywhere? |
I think they're doing a migration. It should be up in a few hours. :) |
@MerlijnWajer awesome. in the meantime, care the paste the patch somewhere else? :) i'm blocked on this very bug... |
It is up again. |
i see - that just completely disables the musicbrainz stuff, do i read this right? |
It removes the custom calculation code and instead just uses libdiscid, which works OK. |
I tried to rip a Microsoft Age of Empires Gold Edition disc containing at first track data about the game, and on following tracks, game's soundtrack.
Ripping failed as following:
The text was updated successfully, but these errors were encountered: