redacted/waffles ready

[MerlijnWajer]

I am trying to make a list of tickets we should finish before we can work with redacted/waffles on the logger part and then have whipper approved by both sites.

• add manpage #73 / clear tutorials (more up to the websites perhaps)
• Loggers #117
• Allow plugins from system directories #135
• Add a requirements.txt file #221
• Ensure that multi-session CDs are still read correctly by whipper #174
• Finding offset fails for one drive "file size 0 did not match expected size" #234 (even though it's an upstream bug I think it needs to be fixed too because it affects a big number of users)
• Go over cdparanoia error types and see if there is one that indicates that rips were definitely lossy #294

Anything else? We might have to rework the logger interface so that it can also call (external) binaries.

I didn't make a Milestone for this because (AFAIK) tickets can be only part of one milestone.

[MerlijnWajer]

@JoeLametta - any comments? I'm trying to get the ball rolling again on this.

[peaveyman]

We need to find out for sure which logger is going to be acceptable for redacted. And if redacted is good with it waffles will be.

[MerlijnWajer]

It seems like the current logger is fine - so we don't need #117. It's unclear if we will need #135. #221 would be nice to have, but for testing purposes we don't need it. #294 is important, though. #174 seems not that important for red right now since it mostly affects CDs with extra data, but we should get that fixed soon as well.

[peaveyman]

I can't see how 135 and 221 would be needed.

[JoeLametta]

1. Loggers #117 I don't consider it a blocker: I'll surely update the README to clarify logger plugins current status. I may also update the morituri-eaclogger (or discontinue it).
2. Add a requirements.txt file #221 I would say it's 99% done: again, not a blocker.
3. Ensure that multi-session CDs are still read correctly by whipper #174 Would be nice having this fixed
4. Allow plugins from system directories #135 Would be nice having this fixed: not a blocker.
5. Go over cdparanoia error types and see if there is one that indicates that rips were definitely lossy #294 I think this is needed.

Clear tutorials (more up to the websites perhaps)

Maybe #73?

[itismadness]

So in looking to implement this within a logchecker for Orpheus, one of the biggest hurdles I think we face is just knowing what are the possible logs that whipper may output that a user may check against. This includes a perfect log, but also what a log of a rip that has totally failed (or failed as much as whipper would allow while still producing a log). I can get an idea of it looking through the logger.py module that produces the YAML, but just concrete examples would be wonderfully helpful.

(Thanks for making the default log produced using YAML and not just straight text which has made parsing these things way easier than EAC/XLD).

[MerlijnWajer]

Alright. Going to try to get this rolling ASAP now. Remaining three tickets are all assigned to me it seems. ;)

[nafanz]

It is wonderful that it was approved at Orpheus.
I hope that it will also be available for RED and Waffles.

[peaveyman]

I can't speak for RED but as for Waffles, when it gets back online you can expect Whipper to be an approved ripper.

[JoeLametta]

Even if it's an upstream bug I think #234 needs to be fixed too because it affects a big number of users.

[7596ff]

Is this still a priority?

[JoeLametta]

Is this still a priority?

Hi, those are just some of the issues scheduled for milestone 1.0. Unfortunately I don't have enough time / experience to handle everything on my own (that's why progress is slow) but I try to review every issue / pull request in a timely manner.
Of course every contribution is encouraged and appreciated.

[lighterowl]

I can't speak for RED but as for Waffles, when it gets back online you can expect Whipper to be an approved ripper.

It never did. 😢

[in-plaintext]

What is the current state of the program on RED?