From 07bd0348f30a8f929df8dba777ba5072dbc15e16 Mon Sep 17 00:00:00 2001 From: JoeLametta Date: Thu, 17 Sep 2020 18:07:28 +0000 Subject: [PATCH] Add checks and warnings for (known) cdparanoia's upstream bugs Fixes #495. Signed-off-by: JoeLametta --- whipper/program/cdparanoia.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/whipper/program/cdparanoia.py b/whipper/program/cdparanoia.py index 725b36a6..5c4b7793 100644 --- a/whipper/program/cdparanoia.py +++ b/whipper/program/cdparanoia.py @@ -283,6 +283,24 @@ def start(self, runner): stopTrack, common.framesToHMSF(stopOffset)), self.path]) logger.debug('running %s', (" ".join(argv), )) + if self._offset > 587: + logger.warning( + "because of a cd-paranoia upstream bug whipper may fail to " + "work correctly when using offset values > 587 (current " + "value: %d) and print warnings like this: 'file size 0 did " + "not match expected size'. For more details please check the " + "following issues: " + "https://github.com/whipper-team/whipper/issues/234 and " + "https://github.com/rocky/libcdio-paranoia/issues/14", + self._offset + ) + if stopTrack == 99: + logger.warning( + "because of a cd-paranoia upstream bug whipper may fail to " + "rip the last track of a CD when it has got 99 of them. " + "For more details please check the following issue: " + "https://github.com/whipper-team/whipper/issues/302" + ) try: self._popen = asyncsub.Popen(argv, bufsize=bufsize,