Skip to content
This repository was archived by the owner on Feb 5, 2023. It is now read-only.

Not all spaces removed from a back-quoted block #44

Open
robertjank opened this issue Sep 28, 2020 · 3 comments
Open

Not all spaces removed from a back-quoted block #44

robertjank opened this issue Sep 28, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@robertjank
Copy link
Collaborator

In projects Frustration and Getting started with Sonic Pi for language ar-SA (Arabic) there are cases where a space following the first back-quote of a pair of back-quotes is not removed. It is unclear whether this is caused by the special character set used for Arabic and the fact that this language is read from right to left.

@robertjank robertjank added the bug Something isn't working label Sep 28, 2020
@wheleph
Copy link
Owner

wheleph commented Nov 7, 2020

@robertjank can you specify the place where you observe this behaviour?

@robertjank
Copy link
Collaborator Author

An example is project Frustration, language ar-SA, file step_2.md, line 7. This line contains 4 back-quotes.
In the input (l10n_master branch), the first and third back-quote are followed by a space and the second and fourth are preceded by a space.
NTTT removes the space after the first and third back-quote, but not the spaces before the second and fourth one.
Similar things happen on lines 19, 25 and 29 of this file.

In step_4.md, line 5, the space after the third back-quote is also not removed (next to the second and fourth back-quote).

@torarve
Copy link

torarve commented Apr 26, 2021

Seems like this is already fixed. Artifact seen on line 7 here is missing after running current code locally:

+ احذف الكتل ` إلى الأبد` و ` عند بدء` بسحبها إلى اللوحة:

becomes

+ احذف الكتل `إلى الأبد` و `عند بدء` بسحبها إلى اللوحة:

compared to value from https://raw.githubusercontent.com/raspberrypilearning/frustration/l10n_master/ar-SA/step_2.md:

+ احذف الكتل ` إلى الأبد` و ` عند بدء` بسحبها إلى اللوحة:

I was not able to see all the cases as described. @robertjank Could you take a look?

Maybe we should get some translaters for arabic to look at the output?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants