Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Mixed Content tests #50

Open
annevk opened this issue Aug 28, 2023 · 1 comment
Open

Incorrect Mixed Content tests #50

annevk opened this issue Aug 28, 2023 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Aug 28, 2023

web-platform-tests/wpt#40632 looks incorrect to me. The equivalent of a network error should happen, which doesn't end up yielding an exception, but rather an error event.

@ricea
Copy link
Collaborator

ricea commented Aug 29, 2023

Yes, I think you're right.

Main fetch step 7 sets response to a network error, then step 29 runs "fetch response handover". Then at step 4 of fetch response handover we queue a task to run "process response" which takes us back to the WebSocket standard's establish a WebSocket connection step 11, which then calls "fail the WebSocket connection", which loops through RFC6455 and ends up back at "When the WebSocket connection is closed" which fires "error" and "close" events.

I don't really want to add a redundant mixed content check to the WebSocket standard, so I'm leaning towards aligning Blink's behaviour with the standard as written, ie. firing error and close events. I could add a console log to make up for the loss of diagnostic information.

@zcorpan Do you have opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants