Linkify all class definitions #913
Conversation
| @@ -3539,7 +3539,7 @@ lt="WritableStreamDefaultWriter(stream)">new WritableStreamDefaultWriter(<var>st | |||
| 1. Return *this*.[[closedPromise]]. | |||
| </emu-alg> | |||
|
|
|||
| <h5 id="default-writer-desiredSize" attribute for="WritableStreamDefaultWriter" lt="desiredSize">get desiredSize</h5> | |||
| <h5 id="default-writer-desired-size" attribute for="WritableStreamDefaultWriter" lt="desiredSize">get desiredSize</h5> | |||
There was a problem hiding this comment.
I changed this to have consistent spelling with the other IDs and couldn’t find any other references to it. I am assuming I’m not breaking anything here?
| @@ -1240,13 +1240,13 @@ would look like | |||
|
|
|||
| <pre><code class="lang-javascript"> | |||
| class ReadableStreamDefaultReader { | |||
| constructor(stream) | |||
| <a href="#default-reader-constructor">constructor(stream)</a> | |||
There was a problem hiding this comment.
This is desirable for readability of the output, but it sure makes the source unreadable.
@tabatkins Can Bikeshed help our markup look nicer here?
There was a problem hiding this comment.
I had a different markup in #872 but the consensus was that simple a tags were preferred. I think these links could be automatically generated, so I am in favor of somehow using bikeshed for this.
There was a problem hiding this comment.
If we end up doing what @ricea suggested in #907 we'd align more with existing specs so I wouldn't suggest adding anything to Bikeshed for this definition.
That said, the domintro blocks (as proposed in #907) are also not very readable in the source either. See e.g. https://github.com/domenic/async-local-storage/blob/master/spec.bs#L239-L249 for my latest attempt. (Explicit <p>s needed because of speced/bikeshed#1203.)
Personally I'm not too worried about the source readability here.
domenic
added
the
editorial
|
🎉🎉🎉 |
As a follow-up to #872, I linkified all the other class definitions as well.
Preview | Diff