BroadcastChannel: Ignore messages from detached iframes / closing workers #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For BroadcastChannel instances associated with detached iframes or closing workers, update the specification to mention that calls to postMessage should be ignored without throwing an exception.
domenic
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
LGTM with nit. This also makes calling postMessage() while in bfcache a no-op, but I think that is not really observable today so it should be fine and not require any additional tests.
(Details: The only way I can think of to call postMessage() from a bfcached page is to get a reference to a BroadcastChannel from that global before the page enters bfcache, then after it enters bfcache call broadcastChannel.postMessage() "from the outside". However, browsers don't let you bfcache iframes or windows with an opener today, from what I understand. So there is no way to get such a reference.)
|
Also once this is merged (or even before since it looks like we have consensus) please remember to remove the |
|
Thanks for the review, @domenic. I'll submit a CL today that removes tentative from the test file names. |
|
Awesome! I will give this ~24 hours in case anyone from #7219 wants to take a look (/cc @wanderview @asutherland @cdumez) but it looks great. Special congrats on this being your first contribution; it's very clean! |
|
I also like this very much, thank you! |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 5, 2021
The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 5, 2021
The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 5, 2021
The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 10, 2021
… closed worker tests permanent, a=testonly Automatic update from web-platform-tests BroadcastChannel: Make detached iframe / closed worker tests permanent The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781} -- wpt-commits: 74a7f0ac9da8a098c16e421de381d5bcc1c3b5f7 wpt-pr: 31513
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 10, 2021
… closed worker tests permanent, a=testonly Automatic update from web-platform-tests BroadcastChannel: Make detached iframe / closed worker tests permanent The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781} -- wpt-commits: 74a7f0ac9da8a098c16e421de381d5bcc1c3b5f7 wpt-pr: 31513
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The spec is being updated [1] to indicate that messages from BroadcastChannel instances associated with detached iframe / closed worker contexts should be ignored, which means that these tests no longer need to be marked 'tentative'. Note that this CL doesn't introduce any changes to the tests. [1] whatwg/html#7296 Bug: 1239274 Change-Id: I3e506493175b5e22913c35510454e8bef5f1e5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259423 Commit-Queue: Ben Kelly <[email protected]> Auto-Submit: Andrew Williams <[email protected]> Reviewed-by: Ben Kelly <[email protected]> Cr-Commit-Position: refs/heads/main@{#938781} NOKEYCHECK=True GitOrigin-RevId: f49494ed94e1a04b376707b3858c7c2b970e1148
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BroadcastChannel instances associated with detached iframes or closing workers, update the specification to mention that calls to postMessage should be ignored without throwing an exception.
This update should align with the consensus from #7219 regarding how to handle these two cases.
/acknowledgements.html ( diff )
/web-messaging.html ( diff )