Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile syn dependency due to missing feature #12

Closed
ExpHP opened this issue Mar 2, 2020 · 2 comments · Fixed by #13
Closed

Can't compile syn dependency due to missing feature #12

ExpHP opened this issue Mar 2, 2020 · 2 comments · Fixed by #13

Comments

@ExpHP
Copy link

ExpHP commented Mar 2, 2020

[package]
name = "gen-example"
version = "0.1.0"
authors = ["Michael Lamparski <[email protected]>"]
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
genawaiter = "0.99.0"
C:/Users/diago/.cargo/bin/cargo.exe run --color=always
   Compiling genawaiter-proc-macro v0.99.0
error[E0432]: unresolved imports `syn::FnArg`, `syn::ItemFn`
  --> C:\Users\diago\.cargo\registry\src\github.aaakk.us.kg-1ecc6299db9ec823\genawaiter-proc-macro-0.99.0\src\lib.rs:20:5
   |
20 |     FnArg,
   |     ^^^^^ no `FnArg` in the root
21 |     Ident,
22 |     ItemFn,
   |     ^^^^^^ no `ItemFn` in the root

It seems to me that genawaiter-proc-macro requires the "full" feature of syn, but does not enable it. (How is this not failing on CI testing?)

@DevinR528
Copy link
Collaborator

DevinR528 commented Mar 2, 2020

Hmm that's a good question. When running the tests the features are included from the [dev-dependencies] right? My guess is that because futures-macro uses syn = ... features = ["full"] so as features are additive this was always secretly enabled. I'll PR to add this.

Thanks for the catch!!

@whatisaphone
Copy link
Owner

Thanks for the report. Devin's fix has been released in v0.99.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants