Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Maven-friendly way to use UI build files in API jar #120

Open
JohnKallies opened this issue Jan 12, 2022 · 0 comments
Open

Implement Maven-friendly way to use UI build files in API jar #120

JohnKallies opened this issue Jan 12, 2022 · 0 comments
Labels
dev-tooling Changes that enhance/improve development

Comments

@JohnKallies
Copy link
Contributor

As an OSMT developer, I want to have want a simple typical Angular development workflow with the Angular build files available in the Spring app jar file.

Currently, ui/angular.json uses this to put the Angular files in the API module, in a directory that is ignored by git.

  • "outputPath": "../api/src/main/resources/ui/",

Maven has a more idiomatic way to do this, using the Maven Assembly plugin

This card proposes:

  • In the UI Module:

    • Building the Angular files in the expected ui/dist folder
    • Building a jar for the UI module using mvn install
  • In the API module:

    • We should expect to declare a dependency on the UI module jar
    • Maven Assembly should be configured to unpack that jar in the API module's resources directory

When complete, ng serve should still proxy front end requests on port 4200, from the ui/dist folder.

This will also simplify future work related to whitelabelling, allowing the UI code and npm tasks to cleanly live within the boundaries of the UI module.

@JohnKallies JohnKallies added the dev-tooling Changes that enhance/improve development label Jan 12, 2022
@JohnKallies JohnKallies moved this to Ungroomed in OSMT Issues Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tooling Changes that enhance/improve development
Development

No branches or pull requests

1 participant