adds support for auth proxy header #1859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyJhb
force-pushed
the
proxyauthheader
branch
4 times, most recently
from
714efe6 to
2a306f4
Compare
eyJhb
changed the title
eyJhb
force-pushed
the
proxyauthheader
branch
2 times, most recently
from
d46d469 to
7a7a494
Compare
Useful if you have authentication in front of wger, and want to use that instead of wgers authentication/signup methods.
|
Maybe this should only be checked for |
5 tasks
|
BTW I haven't forgotte about this PR, but since it would add a new auth method I'd like to make sure we do it right. I've added this to the 2.4 backlog (so after the flexible routines get merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful if you have authentication in front of wger, and want to use that instead of wgers authentication/signup methods.
Proposed Changes
Added a new setting, which can be used to setup proxy auth header, e.g. using Authelia to authenticate + create users on the instance.
Fixes #1847 , and potential VERY SIMPLE solution for #1805 ( #1797 )
Please check that the PR fulfills these requirements
Other questions
(e.g. database migration)? No
Remaining work