Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask connector breaks Coinbase connector in iOS Safari #4058

Closed
1 task done
lochie opened this issue Jun 17, 2024 · 3 comments
Closed
1 task done

MetaMask connector breaks Coinbase connector in iOS Safari #4058

lochie opened this issue Jun 17, 2024 · 3 comments

Comments

@lochie
Copy link
Contributor

lochie commented Jun 17, 2024

Check existing issues

Describe the bug

It looks like metaMask connector causes coinbaseWallet connector to not be able to open it's popup on first tap in iOS Safari.

Video reproduction (using simulator):

CleanShot.06-17.at.21.27.47.mp4

Minimal Reproducible Example:

View the following on iOS Safari. Also reproducible in Simulator.

With MetaMask:

Without MetaMask

Link to Minimal Reproducible Example

No response

Steps To Reproduce

  1. Set up a blank project with the metaMask and coinbaseWallet connectors.
  2. Attempt to connect with Coinbase on iOS Safari.
  3. Error Pop up window failed to open (error message from coinbase sdk, see ref)
  4. Attempting to connect again after this error will behave as expected.

What Wagmi package(s) are you using?

@wagmi/connectors

Wagmi Version

2.10.2

Viem Version

2.13.0

TypeScript Version

5.0.4

Anything else?

No response

@imaksp
Copy link

imaksp commented Jun 25, 2024

This must be the reason it didn't work for us on Mobile Safari even after Coinbase team has fixed it , we targeted v3 SDK to solve it at that time, also we are not even using metaMask connector but it gets imported due to some tree shaking issue with esbuild builder of Angular, I was going to create issue & PR about adding separate export for each connector so it can be imported like this:

import walletConnect from '@wagmi/connectors/walletConnect';

@tmm tmm closed this as completed in 43fa971 Jun 27, 2024
@lochie
Copy link
Contributor Author

lochie commented Jun 28, 2024

thank you @tmm 🫡

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants