fix: format abi item fallback formatting #259
Merged
+27
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #253
As in the issue description, there were changes in the #229 for
parseAbiItem
, but there wasn't a corresponding change made for theformatAbiItem
. This PR fixes that.Also, I spotted that
FallbackSignature
type was only acceptingfallback() external
, and notfallback() external payable
, which it should have, so I fixed that as it was a change related to the issue.PR-Codex overview
This PR focuses on enhancing the formatting of
fallback
functions in theformatAbiItem
utility, ensuring that the output accurately reflects thestateMutability
of the ABI items.Detailed summary
expected
values in tests to includeexternal
forfallback
functions.formatAbiItem
function to returnfallback() external
andfallback() external payable
based onstateMutability
.