Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings of test() and test.skip() differ #749

Closed
mrazauskas opened this issue Sep 8, 2024 · 1 comment · Fixed by #754
Closed

Typings of test() and test.skip() differ #749

mrazauskas opened this issue Sep 8, 2024 · 1 comment · Fixed by #754
Labels
bug modifiers Debugging and planning helpers

Comments

@mrazauskas
Copy link
Contributor

Technically all is correct, of course. But... the problem is that some tooling recommends removing await, if .skip is used with async test:

Screenshot 2024-09-08 at 08 40 08

Here that is just a misleading recommendation. I did not try, but in some situation await could get removed automatically (after applying lint rules on save). Does not look like this is needed, if the test is disable only temporary.

@wellwelwel wellwelwel added bug modifiers Debugging and planning helpers labels Sep 8, 2024
@wellwelwel
Copy link
Owner

wellwelwel commented Sep 8, 2024

Although TypeScript checks the compilation, I really need to create overload tests to avoid these situations.

Thanks for the report, @mrazauskas 🙋🏻‍♂️

Linking this to remember:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug modifiers Debugging and planning helpers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants