From 0cb87a7215251305051c456dfd2dc9936dbb305e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Yi=C4=9Fit=20FINDIKLI?= <yigitfindikli@gmail.com>
Date: Tue, 12 Feb 2019 15:52:23 +0300
Subject: [PATCH] fixed #6822 SplitButton & TieredMenu - double click on item
 reloads the page

---
 src/app/components/splitbutton/splitbutton.css | 4 ++++
 src/app/components/splitbutton/splitbutton.ts  | 2 +-
 src/app/components/tieredmenu/tieredmenu.css   | 1 +
 src/app/components/tieredmenu/tieredmenu.ts    | 2 +-
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/app/components/splitbutton/splitbutton.css b/src/app/components/splitbutton/splitbutton.css
index eb7f0952ea7..446609afc5a 100644
--- a/src/app/components/splitbutton/splitbutton.css
+++ b/src/app/components/splitbutton/splitbutton.css
@@ -23,4 +23,8 @@
 
 .ui-fluid .ui-splitbutton .ui-button.ui-splitbutton-menubutton {
     width: 2em;
+}
+
+.ui-splitbutton .ui-menuitem-link {
+    cursor: pointer;
 }
\ No newline at end of file
diff --git a/src/app/components/splitbutton/splitbutton.ts b/src/app/components/splitbutton/splitbutton.ts
index aee69fa158f..223778b17e6 100644
--- a/src/app/components/splitbutton/splitbutton.ts
+++ b/src/app/components/splitbutton/splitbutton.ts
@@ -19,7 +19,7 @@ import {RouterModule} from '@angular/router';
                 <ul class="ui-menu-list ui-helper-reset">
                     <ng-template ngFor let-item [ngForOf]="model">
                         <li class="ui-menuitem ui-widget ui-corner-all" role="menuitem" *ngIf="item.visible !== false">
-                            <a *ngIf="!item.routerLink" [href]="item.url||'#'" class="ui-menuitem-link ui-corner-all" [attr.target]="item.target"
+                            <a *ngIf="!item.routerLink" [attr.href]="item.url||null" class="ui-menuitem-link ui-corner-all" [attr.target]="item.target"
                                 [ngClass]="{'ui-state-disabled':item.disabled}" (click)="itemClick($event, item)">
                                 <span [ngClass]="'ui-menuitem-icon'" [class]="item.icon" *ngIf="item.icon"></span>
                                 <span class="ui-menuitem-text">{{item.label}}</span>
diff --git a/src/app/components/tieredmenu/tieredmenu.css b/src/app/components/tieredmenu/tieredmenu.css
index 9f563133602..8c48075c7c0 100644
--- a/src/app/components/tieredmenu/tieredmenu.css
+++ b/src/app/components/tieredmenu/tieredmenu.css
@@ -25,6 +25,7 @@
 }
 
 .ui-tieredmenu .ui-menuitem-link {
+    cursor: pointer;
     padding: .25em;
     display: block;
     position: relative;
diff --git a/src/app/components/tieredmenu/tieredmenu.ts b/src/app/components/tieredmenu/tieredmenu.ts
index 60af362951f..1b21f4b8037 100644
--- a/src/app/components/tieredmenu/tieredmenu.ts
+++ b/src/app/components/tieredmenu/tieredmenu.ts
@@ -14,7 +14,7 @@ import {RouterModule} from '@angular/router';
                 <li *ngIf="!child.separator" #listItem [ngClass]="{'ui-menuitem ui-widget ui-corner-all':true,'ui-menuitem-active':listItem==activeItem,'ui-helper-hidden': child.visible === false}"
                     [class]="child.styleClass" [ngStyle]="child.style"
                     (mouseenter)="onItemMouseEnter($event, listItem, child)" (mouseleave)="onItemMouseLeave($event)">
-                    <a *ngIf="!child.routerLink" [href]="child.url||'#'" class="ui-menuitem-link ui-corner-all" [attr.target]="child.target" [attr.title]="child.title" [attr.id]="child.id"
+                    <a *ngIf="!child.routerLink" [attr.href]="child.url||null" class="ui-menuitem-link ui-corner-all" [attr.target]="child.target" [attr.title]="child.title" [attr.id]="child.id"
                         [ngClass]="{'ui-state-disabled':child.disabled}" (click)="itemClick($event, child)">
                         <span class="ui-menuitem-icon" *ngIf="child.icon" [ngClass]="child.icon"></span>
                         <span class="ui-menuitem-text">{{child.label}}</span>